staging: bcm2835-camera: Remove check of the number of buffers supplied
authorDave Stevenson <dave.stevenson@raspberrypi.org>
Wed, 4 Jul 2018 16:01:15 +0000 (17:01 +0100)
committerpopcornmix <popcornmix@gmail.com>
Mon, 13 May 2019 23:08:12 +0000 (00:08 +0100)
Before 9384167 there was a need to ensure that there were sufficient
buffers supplied from the user to cover those being sent to the VPU
(always 1).
With 9384167 the buffers are linked 1:1 between MMAL and V4L2,
therefore there is no need for that check, and indeed it is wrong
as there is no need to submit all the buffers before starting streaming.

Fixes: 9384167 "staging: bcm2835-camera: Remove V4L2/MMAL buffer remapping"

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c

index 6c643cb..9a0c25b 100644 (file)
@@ -1338,16 +1338,6 @@ static int port_enable(struct vchiq_mmal_instance *instance,
        if (port->enabled)
                return 0;
 
-       /* ensure there are enough buffers queued to cover the buffer headers */
-       if (port->buffer_cb) {
-               hdr_count = 0;
-               list_for_each(buf_head, &port->buffers) {
-                       hdr_count++;
-               }
-               if (hdr_count < port->current_buffer.num)
-                       return -ENOSPC;
-       }
-
        ret = port_action_port(instance, port,
                               MMAL_MSG_PORT_ACTION_TYPE_ENABLE);
        if (ret)