kernel/extable.c: use address-of operator on section symbols 60/292560/1
authorNathan Chancellor <natechancellor@gmail.com>
Tue, 7 Apr 2020 03:09:27 +0000 (20:09 -0700)
committerSeung-Woo Kim <sw0312.kim@samsung.com>
Mon, 8 May 2023 09:34:34 +0000 (18:34 +0900)
Clang warns:

../kernel/extable.c:37:52: warning: array comparison always evaluates to
a constant [-Wtautological-compare]
        if (main_extable_sort_needed && __stop___ex_table > __start___ex_table) {
                                                          ^
1 warning generated.

These are not true arrays, they are linker defined symbols, which are just
addresses.  Using the address of operator silences the warning and does
not change the resulting assembly with either clang/ld.lld or gcc/ld
(tested with diff + objdump -Dr).

Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Link: https://github.com/ClangBuiltLinux/linux/issues/892
Link: http://lkml.kernel.org/r/20200219202036.45702-1-natechancellor@gmail.com
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[sw0312.kim: cherry-pick upstream commit 63174f61dfae to resolve gcc-12 build issue]
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Change-Id: Iead005392ebb5b2b334a7eae324883cc5f75c2cc

kernel/extable.c

index 4f06fc3..daa4628 100644 (file)
@@ -41,7 +41,8 @@ u32 __initdata __visible main_extable_sort_needed = 1;
 /* Sort the kernel's built-in exception table */
 void __init sort_main_extable(void)
 {
-       if (main_extable_sort_needed && __stop___ex_table > __start___ex_table) {
+       if (main_extable_sort_needed &&
+           &__stop___ex_table > &__start___ex_table) {
                pr_notice("Sorting __ex_table...\n");
                sort_extable(__start___ex_table, __stop___ex_table);
        }