xfs: fix uninit warning in xfs_growfs_data
authorDarrick J. Wong <djwong@kernel.org>
Fri, 7 Jul 2023 01:00:59 +0000 (18:00 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Sat, 8 Jul 2023 03:13:41 +0000 (20:13 -0700)
Quiet down this gcc warning:

fs/xfs/xfs_fsops.c: In function ‘xfs_growfs_data’:
fs/xfs/xfs_fsops.c:219:21: error: ‘lastag_extended’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  219 |                 if (lastag_extended) {
      |                     ^~~~~~~~~~~~~~~
fs/xfs/xfs_fsops.c:100:33: note: ‘lastag_extended’ was declared here
  100 |         bool                    lastag_extended;
      |                                 ^~~~~~~~~~~~~~~

By setting its value explicitly.  From code analysis I don't think this
is a real problem, but I have better things to do than analyse this
closely.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
fs/xfs/xfs_fsops.c

index 839ca9a..a19ee48 100644 (file)
@@ -93,7 +93,7 @@ xfs_growfs_data_private(
        xfs_agnumber_t          nagimax = 0;
        xfs_rfsblock_t          nb, nb_div, nb_mod;
        int64_t                 delta;
-       bool                    lastag_extended;
+       bool                    lastag_extended = false;
        xfs_agnumber_t          oagcount;
        struct xfs_trans        *tp;
        struct aghdr_init_data  id = {};