cifs: remove repeated state change in dfs tree connect
authorShyam Prasad N <sprasad@microsoft.com>
Sun, 16 Jan 2022 13:28:34 +0000 (13:28 +0000)
committerSteve French <stfrench@microsoft.com>
Wed, 19 Jan 2022 17:10:55 +0000 (11:10 -0600)
cifs_tree_connect checks and sets the tidStatus for the tcon.
cifs_tree_connect also calls a dfs specific tree connect
function, which also does similar checks. This should
not happen. Removing it with this change.

Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/connect.c

index 4a31a9b..6740a7c 100644 (file)
@@ -4295,16 +4295,6 @@ static int __tree_connect_dfs_target(const unsigned int xid, struct cifs_tcon *t
        struct dfs_cache_tgt_iterator *tit;
        bool target_match;
 
-       /* only send once per connect */
-       spin_lock(&cifs_tcp_ses_lock);
-       if (tcon->tidStatus != CifsNew &&
-           tcon->tidStatus != CifsNeedTcon) {
-               spin_unlock(&cifs_tcp_ses_lock);
-               return 0;
-       }
-       tcon->tidStatus = CifsInTcon;
-       spin_unlock(&cifs_tcp_ses_lock);
-
        extract_unc_hostname(server->hostname, &tcp_host, &tcp_host_len);
 
        tit = dfs_cache_get_tgt_iterator(tl);