[messaging_sms] method_returns_undefined
authorWitold Choinkowski <w.choinkowsk@samsung.com>
Thu, 26 Sep 2013 15:20:58 +0000 (17:20 +0200)
committerGerrit Code Review <gerrit@gerrit.vlan144.tizendev.org>
Mon, 30 Sep 2013 09:33:31 +0000 (09:33 +0000)
Change-Id: I7bde2515ed44354e4857657a4feb66068832d396

15 files changed:
tct-messaging-sms-tizen-tests/messaging/MessageService_sms_sendMessage_without_errorCallback.html
tct-messaging-sms-tizen-tests/messaging/MessageStorage_findMessages_filter_sms_valid.html
tct-messaging-sms-tizen-tests/messaging/MessageStorage_sms_addDraftMessage.html
tct-messaging-sms-tizen-tests/messaging/MessageStorage_sms_addDraftMessage_without_errorCallback.html
tct-messaging-sms-tizen-tests/messaging/MessageStorage_sms_addDraftMessage_without_successCallback.html
tct-messaging-sms-tizen-tests/messaging/MessageStorage_sms_findConversations.html
tct-messaging-sms-tizen-tests/messaging/MessageStorage_sms_findConversations_filter_id.html
tct-messaging-sms-tizen-tests/messaging/MessageStorage_sms_findConversations_filter_to.html
tct-messaging-sms-tizen-tests/messaging/MessageStorage_sms_findMessages_from_with_errorCallback.html
tct-messaging-sms-tizen-tests/messaging/MessageStorage_sms_findMessages_with_sort.html
tct-messaging-sms-tizen-tests/messaging/MessageStorage_sms_updateMessages.html
tct-messaging-sms-tizen-tests/messaging/MessageStorage_sms_updateMessages_without_errorCallback.html
tct-messaging-sms-tizen-tests/messaging/MessageStorage_sms_updateMessages_without_successCallback.html
tct-messaging-sms-tizen-tests/messaging/Messaging_sms_getMessageServices.html
tct-messaging-sms-tizen-tests/messaging/Messaging_sms_getMessageServices_with_errorCallback.html

index f582c45585114dcb451a3446639976d6e4461a64..9ea48e1775391ffe81c9c91c96ffad3165840502 100644 (file)
@@ -39,7 +39,7 @@ setup({ timeout: 90000 });
 
 var t = async_test("MessageService_sms_sendMessage_without_errorCallback", { timeout: 90000 }),
     message, datetime,
-    sendSuccess, returnedValue,
+    sendSuccess, returnedValue = null,
     service, serviceListSuccess, serviceListError;
 
 t.step(function () {
index db857b672c82474033427eec8e3109c26d563265..3dfb97281ae5cffda517831b77344c36b5afe7b1 100644 (file)
@@ -45,7 +45,7 @@ setup({timeout: 90000});
 var t = async_test("MessageStorage_findMessages_filter_sms_valid", {timeout:90000});
 t.step(function () {
     var smsService, findSuccess, findError, typeFilter, serviceSuccess, addSuccess,
-        addedMessage, foundMessage = 0, returnedValue, i, serviceError;
+        addedMessage, foundMessage = 0, returnedValue = null, i, serviceError;
 
     findSuccess = t.step_func(function (messages) {
         assert_greater_than(messages.length, 0, "Received empty messages array");
@@ -56,6 +56,7 @@ t.step(function () {
             }
         }
         assert_equals(foundMessage, 1, "Incorrect number of found messages");
+        assert_equals(returnedValue, undefined, "Incorrect returned value");
         t.done();
     });
 
@@ -67,7 +68,6 @@ t.step(function () {
         addedMessage = message;
         typeFilter = new tizen.AttributeFilter("type", "EXACTLY", "messaging.sms");
         returnedValue = smsService.messageStorage.findMessages(typeFilter, findSuccess, findError);
-        assert_equals(returnedValue, undefined, "Incorrect returned value");
     });
 
     serviceSuccess = t.step_func(function (services) {
index 81048a2896ac4d06fc648029166d429cbfdf2576..4ed7bd99c1c2b14a6d637d8dcd62a74f507ef994 100644 (file)
@@ -41,13 +41,14 @@ setup({timeout: 90000});
 var t = async_test("MessageStorage_sms_addDraftMessage", {timeout:90000});
 t.step(function () {
     var serviceSuccess, serviceError, messageService, messageStorage, message,
-        currentDate = new Date(), plainBodyToSet = currentDate.getTime().toString(), returnedValue,
+        currentDate = new Date(), plainBodyToSet = currentDate.getTime().toString(), returnedValue = null,
         addDraftSuccess, addDraftError, filter,
         findMessagesSuccess, findMessagesError;
 
     findMessagesSuccess = t.step_func(function (messages) {
         assert_equals(messages.length, 1, "Received incorrect number of messages");
         assert_equals(messages[0].body.plainBody, plainBodyToSet, "plainBody attribute is incorrect.");
+
         t.done();
     });
 
@@ -56,6 +57,7 @@ t.step(function () {
     });
 
     addDraftSuccess = t.step_func(function () {
+        assert_equals(returnedValue, undefined, "Incorrect returned value.");
         filter = new tizen.AttributeFilter("body.plainBody", "EXACTLY", plainBodyToSet);
         messageStorage.findMessages(filter, findMessagesSuccess, findMessagesError);
     });
@@ -70,8 +72,6 @@ t.step(function () {
         messageStorage = messageService.messageStorage;
         message = new tizen.Message("messaging.sms", {plainBody: plainBodyToSet, to: [TEST_SMS_RECIPIENT]});
         returnedValue = messageStorage.addDraftMessage(message, addDraftSuccess, addDraftError);
-        assert_equals(returnedValue, undefined, "Incorrect returned value.");
-
     });
 
     serviceError = t.step_func(function (error) {
index bc0292f387fa87132cfd713798010ff2f9971cae..dbef37d9dd0dd1eb907ccf356b05753eebeb12ca 100644 (file)
@@ -41,13 +41,15 @@ setup({timeout: 90000});
 var t = async_test("MessageStorage_sms_addDraftMessage_without_errorCallback", {timeout:90000});
 t.step(function () {
     var serviceSuccess, serviceError, messageService, messageStorage, message,
-        currentDate = new Date(), plainBodyToSet = currentDate.getTime().toString(), returnedValue,
+        currentDate = new Date(), plainBodyToSet = currentDate.getTime().toString(), returnedValue = null,
         addDraftSuccess, filter,
         findMessagesSuccess, findMessagesError;
 
     findMessagesSuccess = t.step_func(function (messages) {
         assert_equals(messages.length, 1, "Received incorrect number of messages");
         assert_equals(messages[0].body.plainBody, plainBodyToSet, "plainBody attribute is incorrect.");
+
+        assert_equals(returnedValue, undefined, "Incorrect returned value.");
         t.done();
     });
 
@@ -66,8 +68,6 @@ t.step(function () {
         messageStorage = messageService.messageStorage;
         message = new tizen.Message("messaging.sms", {plainBody: plainBodyToSet, to: [TEST_SMS_RECIPIENT]});
         returnedValue = messageStorage.addDraftMessage(message, addDraftSuccess);
-        assert_equals(returnedValue, undefined, "Incorrect returned value.");
-
     });
 
     serviceError = t.step_func(function (error) {
index 9ead3f237a12dc912b349fedef471bfac0a390a2..4e8cf8b19658b8fe4598fb53d3a9728f7dc13df4 100644 (file)
@@ -41,7 +41,7 @@ setup({timeout: 90000});
 var t = async_test("MessageStorage_sms_addDraftMessage_without_successCallback", {timeout:90000});
 t.step(function () {
     var serviceSuccess, serviceError, messageService, messageStorage, message,
-        returnedValue;
+        returnedValue = null;
 
     serviceSuccess = t.step_func(function (services) {
         assert_greater_than(services.length, 0, "Received empty services array");
index da4934c00cff0379554b556bb2444b8578a98541..7b098ad0bfd0b896bd86d3d8012758195ac0d728 100644 (file)
@@ -47,12 +47,14 @@ var t = async_test("MessageStorage_sms_findConversations", {timeout: 90000}),
     serviceSuccess, serviceError,
     addSuccess, addError,
     conversationSuccess, conversationError,
-    service, newMessage, filter, returnedValue, removeAllSuccess;
+    service, newMessage, filter, returnedValue = null, removeAllSuccess;
 t.step(function () {
 
     conversationSuccess = t.step_func(function (conversations) {
         assert_type(conversations, "array", "conversations");
         assert_greater_than(conversations.length, 0, "Received empty conversations array");
+
+        assert_equals(returnedValue, undefined, "findConversations should return undefined");
         t.done();
     });
 
@@ -64,7 +66,6 @@ t.step(function () {
         filter = new tizen.AttributeFilter("id", "EXACTLY", newMessage.conversationId);
 
         returnedValue = service.messageStorage.findConversations(filter, conversationSuccess, conversationError);
-        assert_equals(returnedValue, undefined, "findConversations should return undefined");
     });
 
     addError = t.step_func(function (error) {
index 5ce1f15f53ec318b215b9d0eb9007c1d253f5892..31ede7226e1c2555c973e9d6134e1ed6f7b897c6 100644 (file)
@@ -44,7 +44,7 @@ Authors:
 setup({timeout: 90000});
 
 var t = async_test("MessageStorage_sms_findConversations_filter_id", {timeout:90000}),
-    serviceSuccess, serviceError, returnedValue,
+    serviceSuccess, serviceError, returnedValue = null,
     addDraftSuccess, addDraftError,
     findMessageSuccess, findMessageError,
     conversationSuccess, conversationError,
@@ -57,6 +57,7 @@ t.step(function () {
         assert_equals(conversations.length, 1, "should find exactly one conversation");
         assert_equals(conversations[0].id, convId, "conversationId should match");
 
+        assert_equals(returnedValue, undefined, "Incorrect returned value");
         t.done();
     });
 
@@ -71,7 +72,6 @@ t.step(function () {
         filter = new tizen.AttributeFilter(
             "id", "EXACTLY", convId);
         returnedValue = service.messageStorage.findConversations(filter, conversationSuccess, conversationError);
-        assert_equals(returnedValue, undefined, "Incorrect returned value");
     });
 
     findMessageError = t.step_func(function (error) {
index 102c608c32dc35a7b5f7e982bded045c8be931c9..f964698a57a6e6db7db32f0c3cf6d15220d086a8 100644 (file)
@@ -45,7 +45,7 @@ setup({timeout: 90000});
 
 var t = async_test("MessageStorage_sms_findConversations_filter_to", {timeout: 90000});
 t.step(function () {
-    var serviceSuccess, serviceError, returnedValue,
+    var serviceSuccess, serviceError, returnedValue = null,
         sendSuccess, sendError,
         conversationSuccess, conversationError,
         service, newMessage, filter,
@@ -56,6 +56,8 @@ t.step(function () {
         assert_greater_than(conversations.length, 0, "Received empty conversations array");
         assert_not_equals(conversations[0].to[0].indexOf(TEST_SMS_RECIPIENT), -1,
             "conversation.to should contain the value we were looking for");
+
+        assert_equals(returnedValue, undefined, "Incorrect returned value");
         t.done();
     });
 
@@ -67,7 +69,6 @@ t.step(function () {
         filter = new tizen.AttributeFilter("to", "CONTAINS", recipient);
 
         returnedValue = service.messageStorage.findConversations(filter, conversationSuccess, conversationError);
-        assert_equals(returnedValue, undefined, "Incorrect returned value");
     });
 
     sendError = t.step_func(function (error) {
index 117d19bc996a94fb7e6d096682b0c5b2711c1eed..ecc34bf19bb98b4411fa34de9e08e16dbe9c8e0c 100644 (file)
@@ -39,7 +39,7 @@ Authors:
 setup({timeout: 90000});
 
 var t = async_test("MessageStorage_sms_findMessages_from_with_errorCallback", {timeout: 90000}),
-    serviceSuccess, serviceError, service, returnedValue, filter, findSuccessCB, findErrorCB,
+    serviceSuccess, serviceError, service, returnedValue = null, filter, findSuccessCB, findErrorCB,
     fromFound, i;
 
 t.step(function () {
index 5aeed119fdb07fd9770a3e5d05ab4522b46e8f77..bdedfd2ef7948ac910c5b0d448b7e7ace45f7be0 100644 (file)
@@ -43,7 +43,7 @@ t.step(function () {
     var getMessageServicesErrorCB, getMessageServicesSuccessCB, messageService, messageStorage,
         message, message_one, count = 0, addDraftSuccessCB, addDraftErrorCB, filter,
         sortMode, findSuccessCB, findErrorCB, i, loadMessageSuccess, loadMessageError,
-        findCounter = 0, loadCounter = 0, returnedValue;
+        findCounter = 0, loadCounter = 0, returnedValue = null;
 
     loadMessageSuccess = t.step_func(function (msg) {
         loadCounter++;
@@ -61,6 +61,8 @@ t.step(function () {
     });
 
     findSuccessCB = t.step_func(function (msg) {
+        assert_equals(returnedValue, undefined, "Incorrect returned value");
+
         assert_greater_than(msg.length, 1, "Received empty msg array");
         findCounter = msg.length;
 
@@ -83,7 +85,6 @@ t.step(function () {
             filter = new tizen.AttributeFilter("body.plainBody", "CONTAINS", message.body.plainBody);
             sortMode = new tizen.SortMode("id", "ASC");
             returnedValue = messageStorage.findMessages(filter, findSuccessCB, findErrorCB, sortMode);
-            assert_equals(returnedValue, undefined, "Incorrect returned value");
         }
     });
 
index 35d892abe29a2903cb8c565658d4d462015aaffc..c7e9e443265e04a3dcd5f606940601e729372758 100644 (file)
@@ -46,7 +46,7 @@ t.step(function () {
         initDictForMutableMessage = smsMessageInitDict, initDictForConstMessage = smsMessageInitDict,
         plainBodyToSetForMutableMessage = plainBodyToSet + "_mutable", plainBodyToSetForConstMessage = plainBodyToSet + "_const",
 
-        addDraftSuccess, addDraftError, addDraftSuccessCounter = 0, returnedValue,
+        addDraftSuccess, addDraftError, addDraftSuccessCounter = 0, returnedValue = null,
         updateSuccess, updateError, mutableMessagefilter, constMessagefilter,
         findMutableMessagesSuccess, findMutableMessagesError, foundMutableMessage, mutable = "MUTABLE",
         findConstMessagesSuccess, findConstMessagesError, foundConstMessage, consts = "CONST",
index e31fb0aad78e2c2937f93c89f13e7588c8b5cb45..7e7f87ced02d07a11a1d00c6fa7b2bf7b2a5a5ae 100644 (file)
@@ -46,7 +46,7 @@ t.step(function () {
         initDictForMutableMessage = smsMessageInitDict, initDictForConstMessage = smsMessageInitDict,
         plainBodyToSetForMutableMessage = plainBodyToSet + "_mutable", plainBodyToSetForConstMessage = plainBodyToSet + "_const",
 
-        addDraftSuccess, addDraftError, addDraftSuccessCounter = 0, returnedValue,
+        addDraftSuccess, addDraftError, addDraftSuccessCounter = 0, returnedValue = null,
         updateSuccess, mutableMessagefilter, constMessagefilter,
         findMutableMessagesSuccess, findMutableMessagesError, foundMutableMessage, mutable = "MUTABLE",
         findConstMessagesSuccess, findConstMessagesError, foundConstMessage, consts = "CONST",
index ac4901102d004bcdeea0a4f12512f7f1b5ed7f42..73a3aa2c86e094d7a3fe85fb9b4ca7109e0cc9c2 100644 (file)
@@ -46,7 +46,7 @@ t.step(function () {
         initDictForMutableMessage = smsMessageInitDict, initDictForConstMessage = smsMessageInitDict,
         plainBodyToSetForMutableMessage = plainBodyToSet + "_mutable", plainBodyToSetForConstMessage = plainBodyToSet + "_const",
 
-        addDraftSuccess, addDraftError, addDraftSuccessCounter = 0, returnedValue;
+        addDraftSuccess, addDraftError, addDraftSuccessCounter = 0, returnedValue = null;
 
     addDraftSuccess = t.step_func(function () {
         addDraftSuccessCounter++;
index b4e3e3e6fdf1fc927435ed3286816a16f49555ec..a72294f20abb70b3136612a35724bd62c441fe66 100644 (file)
@@ -40,7 +40,7 @@ setup({timeout: 90000});
 
 var t = async_test("Messaging_sms_getMessageServices", {timeout: 90000});
 t.step(function () {
-    var serviceSuccess, i, returnedValue;
+    var serviceSuccess, i, returnedValue = null;
 
     serviceSuccess = t.step_func(function (services) {
         assert_equals(returnedValue, undefined, "Incorrect returned value.");
index 3a26f53a7031eab89d222fabbe47eb5e7717a2de..12f29e9d51456c95b1d4e963b514e892dca9d7ca 100644 (file)
@@ -40,7 +40,7 @@ setup({timeout: 90000});
 
 var t = async_test("Messaging_sms_getMessageServices_with_errorCallback", {timeout: 90000});
 t.step(function () {
-    var serviceSuccess, serviceError, i, returnedValue;
+    var serviceSuccess, serviceError, i, returnedValue = null;
 
     serviceSuccess = t.step_func(function (services) {
         assert_equals(returnedValue, undefined, "Incorrect returned value.");