vulkanimage: move fence creation earlier
authorMatthew Waters <matthew@centricular.com>
Sun, 27 Oct 2019 15:27:04 +0000 (02:27 +1100)
committerSebastian Dröge <slomo@coaxion.net>
Mon, 28 Oct 2019 07:22:45 +0000 (07:22 +0000)
Fixes a critical:

GStreamer-CRITICAL **: 02:26:34.698: gst_mini_object_ref: assertion 'mini_object != NULL' failed

ext/vulkan/vkimageidentity.c

index 6c499ee..828b474 100644 (file)
@@ -545,6 +545,10 @@ gst_vulkan_image_identity_transform (GstBaseTransform * bt, GstBuffer * inbuf,
   GError *error = NULL;
   VkResult err;
 
+  fence = gst_vulkan_fence_new (render->device, 0, &error);
+  if (!fence)
+    goto error;
+
   in_mem = gst_buffer_peek_memory (inbuf, 0);
   if (!gst_is_vulkan_image_memory (in_mem)) {
     g_set_error_literal (&error, GST_VULKAN_ERROR, GST_VULKAN_FAILED,
@@ -586,9 +590,6 @@ gst_vulkan_image_identity_transform (GstBaseTransform * bt, GstBuffer * inbuf,
     goto error;
   }
 
-  fence = gst_vulkan_fence_new (render->device, 0, &error);
-  if (!fence)
-    goto error;
 
   {
     VkCommandBufferBeginInfo cmd_buf_info = { 0, };