dmaengine: mediatek: drop bogus pm_runtime_set_active()
authorJohan Hovold <johan+linaro@kernel.org>
Thu, 22 Jun 2023 07:51:50 +0000 (09:51 +0200)
committerVinod Koul <vkoul@kernel.org>
Wed, 12 Jul 2023 16:54:01 +0000 (22:24 +0530)
The runtime PM state must be updated while runtime PM is disabled for
the change to take effect.

Drop the bogus pm_runtime_set_active() which left the PM state set to
suspended (as it should be or the clock would not be enabled when the
device is resumed).

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20230622075150.885-1-johan+linaro@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/mediatek/mtk-uart-apdma.c

index a1517ef..92864c9 100644 (file)
@@ -551,7 +551,6 @@ static int mtk_uart_apdma_probe(struct platform_device *pdev)
        }
 
        pm_runtime_enable(&pdev->dev);
-       pm_runtime_set_active(&pdev->dev);
 
        rc = dma_async_device_register(&mtkd->ddev);
        if (rc)