vulkan: fix some leaks

Fix vk_instance leak when state change fails like in
generic/states unit test.

diff --git a/ext/vulkan/vkupload.c b/ext/vulkan/vkupload.c
index ffe963e..6a139af 100644 (file)
--- a/ext/vulkan/vkupload.c
+++ b/ext/vulkan/vkupload.c
@@ -522,6 +522,8 @@ gst_vulkan_upload_finalize (GObject * object)
   for (i = 0; i < G_N_ELEMENTS (upload_methods); i++) {
     upload_methods[i]->free (vk_upload->upload_impls[i]);
   }
+  g_free (vk_upload->upload_impls);
+  vk_upload->upload_impls = NULL;
 
   G_OBJECT_CLASS (parent_class)->finalize (object);
 }

diff --git a/ext/vulkan/vkutils.c b/ext/vulkan/vkutils.c
index 1c25cb8..aaa6bba 100644 (file)
--- a/ext/vulkan/vkutils.c
+++ b/ext/vulkan/vkutils.c
@@ -247,6 +247,8 @@ gst_vulkan_ensure_element_data (gpointer element,
     if (!gst_vulkan_instance_open (*instance_ptr, &error)) {
       GST_ELEMENT_ERROR (element, RESOURCE, NOT_FOUND,
           ("Failed to create vulkan instance"), ("%s", error->message));
+      gst_object_unref (*instance_ptr);
+      *instance_ptr = NULL;
       g_clear_error (&error);
       return FALSE;
     }