Update code for device state changed callback

Do not call recorder_get_device_state in device state changed callback.
The value from the signal is changed, so don't need to call it in callback.

[Version] 0.2.40
[Profile] Common
[Issue Type] Update
[Dependency module] libmm-camcorder, mmsvc-recorder
[Dependency commit] 6012f7ec5032f940e8446a7aec9a9ee001ba05c6, 19f8d3f79e6df3a6133b70babd28c5eb59f5d514
[Test] [M(T) - Boot=(OK), sdb=(OK), Home=(OK), Touch=(OK), Version=tizen-mobile_20161007.1]

Change-Id: Ie035ece78dd390e1bc54c4b5e169c99b327760ed
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>

diff --git a/packaging/capi-media-recorder.spec b/packaging/capi-media-recorder.spec
index 3a2229d..30acb4d 100644 (file)
--- a/packaging/capi-media-recorder.spec
+++ b/packaging/capi-media-recorder.spec
@@ -1,6 +1,6 @@
 Name:       capi-media-recorder
 Summary:    A Recorder API
-Version:    0.2.40
+Version:    0.2.41
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0

diff --git a/src/recorder.c b/src/recorder.c
index d92643f..89f634c 100644 (file)
--- a/src/recorder.c
+++ b/src/recorder.c
@@ -44,7 +44,6 @@ static GList *g_rec_dev_state_changed_cb_list;
 static int g_rec_dev_state_changed_cb_id;
 static GDBusConnection *g_rec_dev_state_changed_cb_conn;
 static guint g_rec_dev_state_changed_cb_subscribe_id;
-static recorder_device_state_e g_rec_dev_last_state;
 
 
 static void __recorder_device_state_changed_cb(GDBusConnection *connection,
@@ -64,26 +63,14 @@ static void __recorder_device_state_changed_cb(GDBusConnection *connection,
                goto _DONE;
        }
 
-       /* get device and state */
+       /* get device type and state */
        g_variant_get(param, "(i)", &value);
 
-       /* get type only from message */
        type = value >> 16;
-
-       if (recorder_get_device_state(type, &state) != RECORDER_ERROR_NONE) {
-               LOGE("failed to get recorder device state");
-               goto _DONE;
-       }
+       state = 0x0000ffff & value;
 
        LOGD("type %d, state %d", type, state);
 
-       if (state == g_rec_dev_last_state) {
-               LOGW("no need to call recorder device state changed cb [state %d]", state);
-               goto _DONE;
-       }
-
-       g_rec_dev_last_state = state;
-
        tmp_list = g_rec_dev_state_changed_cb_list;
 
        do {
@@ -3205,8 +3192,6 @@ int recorder_add_device_state_changed_cb(recorder_device_state_changed_cb callba
                return ret;
        }
 
-       g_rec_dev_last_state = state;
-
        info = g_new0(recorder_cb_info, 1);
        if (!info) {
                LOGE("info failed");