Remove "TODO" comments from the various places in the code

[Issue#]   LINUXWRT-358
[Problem]  Outdated TODO's, Unnecessary 'include' directives
[Cause]    N/A
[Solution] Removed "TODO" comments

Change-Id: Ia80e1131c3ec8526549ad887d0e24f8fa8444c36

diff --git a/src/jobs/job_exception_base.h b/src/jobs/job_exception_base.h
index 9612bc2..4d35420 100644 (file)
--- a/src/jobs/job_exception_base.h
+++ b/src/jobs/job_exception_base.h
@@ -57,7 +57,6 @@
       protected:                                                               \
         int m_param;                                                         \
     };
-//TODO template for m_param
 
 #define DECLARE_JOB_EXCEPTION(Base, Class, Param)                            \
     class Class :                                                                    \
@@ -89,9 +88,6 @@
             return m_param;                                                  \
         }                                                                    \
     };
-//TODO template for m_param
-
-//TODO maybe use DPL:: DECLARE_EXCEPTION_TYPE instead of creating own
 
 namespace Jobs {
 DECLARE_JOB_EXCEPTION_BASE(DPL::Exception, JobExceptionBase, 0)

diff --git a/src/jobs/plugin_install/job_plugin_install.h b/src/jobs/plugin_install/job_plugin_install.h
index 68a4e11..a8d3386 100644 (file)
--- a/src/jobs/plugin_install/job_plugin_install.h
+++ b/src/jobs/plugin_install/job_plugin_install.h
@@ -68,9 +68,7 @@ class JobPluginInstall :
     void SaveExceptionData(const Jobs::JobExceptionBase &e);
 
   private:
-    //TODO move somewhere this attribute
-    //(as it is in all Jobs...)
-    PluginInstallerContext m_context;
+   PluginInstallerContext m_context;
 
     //TODO move it to base class of all jobs
     //maybe separate JobBase class for this?

diff --git a/src/jobs/widget_install/job_widget_install.cpp b/src/jobs/widget_install/job_widget_install.cpp
index d58a707..a680435 100644 (file)
--- a/src/jobs/widget_install/job_widget_install.cpp
+++ b/src/jobs/widget_install/job_widget_install.cpp
@@ -27,24 +27,10 @@
 #include <limits.h>
 #include <regex.h>
 
-#include <dpl/abstract_waitable_input_adapter.h>
-#include <dpl/abstract_waitable_output_adapter.h>
-#include <dpl/zip_input.h>
-#include <dpl/binary_queue.h>
-#include <dpl/copy.h>
-#include <dpl/assert.h>
-#include <dpl/sstream.h>
-#include <dpl/file_input.h>
 #include <dpl/utils/wrt_utility.h>
 #include <dpl/utils/path.h>
-#include <dpl/wrt-dao-ro/common_dao_types.h>
-#include <dpl/wrt-dao-ro/widget_dao_read_only.h>
-#include <dpl/wrt-dao-ro/global_config.h>
-#include <dpl/wrt-dao-ro/config_parser_data.h>
-#include <dpl/wrt-dao-rw/global_dao.h> // TODO remove
 #include <dpl/localization/w3c_file_localization.h>
 
-#include <libiriwrapper.h>
 #include <pkg-manager/pkgmgr_signal.h>
 #include <app_manager.h>
 
@@ -72,8 +58,6 @@
 #include <widget_install/task_configuration.h>
 #include <widget_install/task_installer_fail.h>
 
-#include <widget_install/widget_install_errors.h>
-#include <widget_install/widget_install_context.h>
 #include <widget_install_to_external.h>
 #include <widget_install/widget_unzip.h>
 

diff --git a/src/jobs/widget_install/task_certify.cpp b/src/jobs/widget_install/task_certify.cpp
index 1c3e75e..8dc83c0 100644 (file)
--- a/src/jobs/widget_install/task_certify.cpp
+++ b/src/jobs/widget_install/task_certify.cpp
@@ -26,7 +26,6 @@
 #include <sstream>
 #include <unistd.h>
 #include <dpl/assert.h>
-#include <appcore-common.h> //TODO is it necessary here?
 #include <pcrecpp.h>
 
 //WRT INCLUDES

diff --git a/src/jobs/widget_install/task_prepare_reinstall.cpp b/src/jobs/widget_install/task_prepare_reinstall.cpp
index 8955c19..dd73268 100644 (file)
--- a/src/jobs/widget_install/task_prepare_reinstall.cpp
+++ b/src/jobs/widget_install/task_prepare_reinstall.cpp
@@ -104,7 +104,6 @@ void TaskPrepareReinstall::StepParseRDSDelta()
     std::ifstream delta(rdsDeltaPath);
 
     if (!delta.is_open()) {
-        // TODO throw exception
         ThrowMsg(Exceptions::RDSDeltaFailure, "rds_delta file is missed");
         return;
     }

diff --git a/src/jobs/widget_uninstall/job_widget_uninstall.cpp b/src/jobs/widget_uninstall/job_widget_uninstall.cpp
index 785cb21..7ce6477 100644 (file)
--- a/src/jobs/widget_uninstall/job_widget_uninstall.cpp
+++ b/src/jobs/widget_uninstall/job_widget_uninstall.cpp
@@ -244,7 +244,7 @@ void JobWidgetUninstall::SendFinishedFailure()
     LogDebug("Call widget uninstall failure finishedCallback");
     GetInstallerStruct().finishedCallback(GetInstallerStruct().userParam,
                                           getRemovedTizenId(),
-                                          m_exceptionCaught); //TODO
+                                          m_exceptionCaught);
     LogDebug("[JobWidgetUninstall] Asynchronous failure callback status sent");
 }
 

diff --git a/src/logic/installer_logic.cpp b/src/logic/installer_logic.cpp
index 5af7000..5376b8c 100644 (file)
--- a/src/logic/installer_logic.cpp
+++ b/src/logic/installer_logic.cpp
@@ -153,7 +153,6 @@ bool InstallerLogic::NextStep(Jobs::Job *job)
 
             switch (job->GetInstallationType()) {
             case Jobs::PluginInstallation:
-                //todo move it somewhere
                 InstallWaitingPlugins();
                 break;
             default: //because of warning

diff --git a/src/misc/widget_location.cpp b/src/misc/widget_location.cpp
index 32d0a16..c4701fb 100644 (file)
--- a/src/misc/widget_location.cpp
+++ b/src/misc/widget_location.cpp
@@ -77,7 +77,6 @@ WidgetLocation::WidgetLocation(const std::string & widgetname,
     } else {
         m_installedPath += WrtDB::GlobalConfig::GetUserInstalledWidgetPath();
     }
-    // TODO clean-up
     if (access(m_widgetSource.c_str(), F_OK) != 0) {
         m_widgetSource = m_installedPath + "/" + m_pkgid;
     }
@@ -100,7 +99,6 @@ WidgetLocation::WidgetLocation(const std::string & widgetname,
     } else {
         m_installedPath += WrtDB::GlobalConfig::GetUserInstalledWidgetPath();
     }
-    // TODO clean-up
     if (access(m_widgetSource.c_str(), F_OK) != 0) {
         m_widgetSource = m_installedPath + "/" + m_pkgid;
     }

diff --git a/src/wrt-installer/wrt-installer.cpp b/src/wrt-installer/wrt-installer.cpp
index 164c6d8..08f0d60 100644 (file)
--- a/src/wrt-installer/wrt-installer.cpp
+++ b/src/wrt-installer/wrt-installer.cpp
@@ -22,19 +22,15 @@
 #include "plugin_utils.h"
 
 #include <map>
-#include <string>
 #include <cstring>
 #include <cstdlib>
 #include <dirent.h>
 #include <sys/resource.h>
 
 #include <dpl/log/log.h>
-#include <dpl/optional.h>
 #include <dpl/optional_typedefs.h>
-#include <dpl/exception.h>
 #include <dpl/wrt-dao-ro/global_config.h>
 #include <dpl/wrt-dao-ro/config_parser_data.h>
-#include <dpl/string.h>
 #include <dpl/abstract_waitable_input_adapter.h>
 #include <dpl/abstract_waitable_output_adapter.h>
 #include <dpl/zip_input.h>
@@ -50,7 +46,6 @@
 
 #include <Elementary.h>
 
-#include <pkg-manager/pkgmgr_signal_interface.h>
 #include <pkg-manager/pkgmgr_signal_dummy.h>
 #include <pkg-manager/pkgmgr_signal.h>