OMAPDSS: VENC: Check for errors from regulator_enable()
authorMark Brown <broonie@opensource.wolfsonmicro.com>
Mon, 19 Mar 2012 14:56:39 +0000 (14:56 +0000)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Mon, 23 Apr 2012 07:48:05 +0000 (10:48 +0300)
It is possible for regulator_enable() to fail and if it does fail that's
generally a bad sign for anything we try to do with the hardware afterwards
so check for and immediately return an error if regulator_enable() fails.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/omap2/dss/venc.c

index 9c3daf7..abfbd4a 100644 (file)
@@ -443,7 +443,9 @@ static int venc_power_on(struct omap_dss_device *dssdev)
        dispc_set_digit_size(dssdev->panel.timings.x_res,
                        dssdev->panel.timings.y_res/2);
 
-       regulator_enable(venc.vdda_dac_reg);
+       r = regulator_enable(venc.vdda_dac_reg);
+       if (r)
+               goto err;
 
        if (dssdev->platform_enable)
                dssdev->platform_enable(dssdev);