spl: Refactor controls for console output
authorSimon Glass <sjg@chromium.org>
Fri, 21 Oct 2022 00:22:42 +0000 (18:22 -0600)
committerTom Rini <trini@konsulko.com>
Mon, 31 Oct 2022 15:01:31 +0000 (11:01 -0400)
The expression in boot_from_devices() is fairly long and appears to be an
artefact from before we could easily call printf(...) and have the call be
nop'd out. So update it to just check CONFIG_SILENT_CONSOLE.

Signed-off-by: Simon Glass <sjg@chromium.org>
Suggested-by: Tom Rini <trini@konsulko.com>
common/spl/spl.c

index 10475cd..91b4adc 100644 (file)
@@ -703,9 +703,7 @@ static int boot_from_devices(struct spl_image_info *spl_image,
                if (CONFIG_IS_ENABLED(SHOW_ERRORS))
                        ret = -ENXIO;
                loader = spl_ll_find_loader(bootdev);
-               if (CONFIG_IS_ENABLED(SERIAL) &&
-                   CONFIG_IS_ENABLED(LIBCOMMON_SUPPORT) &&
-                   !IS_ENABLED(CONFIG_SILENT_CONSOLE)) {
+               if (!IS_ENABLED(CONFIG_SILENT_CONSOLE)) {
                        if (loader)
                                printf("Trying to boot from %s\n",
                                       spl_loader_name(loader));