drm/virtio: Remove restriction of non-zero blob_flags
authorRob Clark <robdclark@chromium.org>
Sat, 19 Feb 2022 17:03:01 +0000 (09:03 -0800)
committerGerd Hoffmann <kraxel@redhat.com>
Fri, 25 Mar 2022 11:28:27 +0000 (12:28 +0100)
With native userspace drivers in guest, a lot of GEM objects need to be
neither shared nor mappable.  And in fact making everything mappable
and/or sharable results in unreasonably high fd usage in host VMM.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Chia-I Wu <olvaffe@gmail.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20220219170301.545432-1-robdclark@gmail.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
drivers/gpu/drm/virtio/virtgpu_ioctl.c

index c708bab..77743fd 100644 (file)
@@ -609,8 +609,7 @@ static int verify_blob(struct virtio_gpu_device *vgdev,
        if (!vgdev->has_resource_blob)
                return -EINVAL;
 
-       if ((rc_blob->blob_flags & ~VIRTGPU_BLOB_FLAG_USE_MASK) ||
-           !rc_blob->blob_flags)
+       if (rc_blob->blob_flags & ~VIRTGPU_BLOB_FLAG_USE_MASK)
                return -EINVAL;
 
        if (rc_blob->blob_flags & VIRTGPU_BLOB_FLAG_USE_CROSS_DEVICE) {