CameraBridgeViewBase synchronizes on a final field
authorPhilipp Hasper <vcs@ioxp.de>
Fri, 3 Mar 2017 15:07:10 +0000 (16:07 +0100)
committerGitHub <noreply@github.com>
Fri, 3 Mar 2017 15:07:10 +0000 (16:07 +0100)
Synchronizing against non-final fields is advised against.

modules/java/generator/src/java/android+CameraBridgeViewBase.java

index ef2af81..5487105 100644 (file)
@@ -38,7 +38,7 @@ public abstract class CameraBridgeViewBase extends SurfaceView implements Surfac
     private Bitmap mCacheBitmap;
     private CvCameraViewListener2 mListener;
     private boolean mSurfaceExist;
-    private Object mSyncObject = new Object();
+    private final Object mSyncObject = new Object();
 
     protected int mFrameWidth;
     protected int mFrameHeight;