(make_instruction): Move argument structure into inner scope and ensure that

all of its fields are initialised before they are used.

diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index bd3f498..b91bc1e 100644 (file)
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,9 @@
+2005-02-23  Nick Clifton  <nickc@redhat.com>
+
+       * crx-dis.c (make_instruction): Move argument structure into inner
+       scope and ensure that all of its fields are initialised before
+       they are used.
+
 2005-02-22  Alan Modra  <amodra@bigpond.net.au>
 
        * arc-ext.c: Warning fixes.

diff --git a/opcodes/crx-dis.c b/opcodes/crx-dis.c
index 84f24be..928b011 100644 (file)
--- a/opcodes/crx-dis.c
+++ b/opcodes/crx-dis.c
@@ -655,10 +655,11 @@ make_instruction (void)
 {
   int i;
   unsigned int shift;
-  argument a;
 
   for (i = 0; i < currInsn.nargs; i++)
     {
+      argument a = { 0 };
+
       a.type = getargtype (instruction->operands[i].op_type);
       if (instruction->operands[i].op_type == cst4
          || instruction->operands[i].op_type == rbase_dispu4)