video: exynos_mipi_dsi: Remove unnecessary NULL check
authorSachin Kamat <sachin.kamat@linaro.org>
Fri, 21 Sep 2012 05:06:47 +0000 (10:36 +0530)
committerFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
Sat, 22 Sep 2012 21:44:37 +0000 (21:44 +0000)
'dsim' is allocated and checked for NULL in the probe function.
Hence this check is redundant. This cleanup also fixes a potential NULL
pointer dereference error when dsim which is NULL references its member
in the error print message.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Inki Dae <inki.dae@samsung.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
drivers/video/exynos/exynos_mipi_dsi_common.c

index 7cc4113..3cd29a4 100644 (file)
@@ -79,11 +79,6 @@ irqreturn_t exynos_mipi_dsi_interrupt_handler(int irq, void *dev_id)
        struct mipi_dsim_device *dsim = dev_id;
        unsigned int intsrc, intmsk;
 
-       if (dsim == NULL) {
-               dev_err(dsim->dev, "%s: wrong parameter\n", __func__);
-               return IRQ_NONE;
-       }
-
        intsrc = exynos_mipi_dsi_read_interrupt(dsim);
        intmsk = exynos_mipi_dsi_read_interrupt_mask(dsim);
        intmsk = ~intmsk & intsrc;