ALSA: hda - Fix a sparse warning about snd_ctl_elem_iface_t
authorTakashi Iwai <tiwai@suse.de>
Wed, 25 Jul 2018 21:00:51 +0000 (23:00 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 26 Jul 2018 06:31:41 +0000 (08:31 +0200)
The knew->iface field is in snd_ctl_elem_iface_t, which is with
__bitwise, hence it can't be converted implicitly from integer.
Give an explicit cast for the invalid type.

Spotted by sparse:
  sound/pci/hda/hda_codec.c:3280:25: warning: restricted snd_ctl_elem_iface_t degrades to integer

Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_codec.c

index 6d0c0b1..0a50855 100644 (file)
@@ -3277,8 +3277,8 @@ int snd_hda_add_new_ctls(struct hda_codec *codec,
        for (; knew->name; knew++) {
                struct snd_kcontrol *kctl;
                int addr = 0, idx = 0;
-               if (knew->iface == -1)  /* skip this codec private value */
-                       continue;
+               if (knew->iface == (__force snd_ctl_elem_iface_t)-1)
+                       continue; /* skip this codec private value */
                for (;;) {
                        kctl = snd_ctl_new1(knew, codec);
                        if (!kctl)