Corrected invalid return values of audio effect APIs
authorSangchul Lee <sc11.lee@samsung.com>
Thu, 4 Apr 2013 09:09:02 +0000 (18:09 +0900)
committerSangchul Lee <sc11.lee@samsung.com>
Thu, 4 Apr 2013 09:19:07 +0000 (18:19 +0900)
Change-Id: If45ad969bb960cec374a3c3d5643e6572315ae5e

packaging/libmm-player.spec
src/mm_player_audioeffect.c

index 687383e..6805ba4 100644 (file)
@@ -1,6 +1,6 @@
 Name:       libmm-player
 Summary:    Multimedia Framework Player Library
-Version:    0.2.16
+Version:    0.2.17
 Release:    0
 Group:      System/Libraries
 License:    Apache-2.0
index 6141118..8fea055 100644 (file)
@@ -832,13 +832,11 @@ mm_player_audio_effect_custom_get_eq_bands_width(MMHandleType hplayer, int band_
                return MM_ERROR_PLAYER_SOUND_EFFECT_NOT_SUPPORTED_FILTER;
        }
 
-       return_val_if_fail( player->pipeline, MM_ERROR_PLAYER_NOT_INITIALIZED );
-
        eq_num = PLAYER_INI()->audio_effect_custom_eq_band_num;
        if (band_idx < 0 || band_idx > eq_num-1)
        {
                debug_error("out of range, invalid band_idx(%d)", band_idx);
-               result = MM_ERROR_PLAYER_INTERNAL;
+               result = MM_ERROR_INVALID_ARGUMENT;
        }
        else
        {
@@ -871,13 +869,11 @@ mm_player_audio_effect_custom_get_eq_bands_freq(MMHandleType hplayer, int band_i
                return MM_ERROR_PLAYER_SOUND_EFFECT_NOT_SUPPORTED_FILTER;
        }
 
-       return_val_if_fail( player->pipeline, MM_ERROR_PLAYER_NOT_INITIALIZED );
-
        eq_num = PLAYER_INI()->audio_effect_custom_eq_band_num;
        if (band_idx < 0 || band_idx > eq_num-1)
        {
                debug_error("out of range, invalid band_idx(%d)", band_idx);
-               result = MM_ERROR_PLAYER_INTERNAL;
+               result = MM_ERROR_INVALID_ARGUMENT;
        }
        else
        {