drm/vc4: crtc: Restrict HACT_ACT setup to DSI
authorMaxime Ripard <maxime@cerno.tech>
Wed, 27 May 2020 15:47:58 +0000 (17:47 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Wed, 10 Jun 2020 09:09:38 +0000 (11:09 +0200)
The HACT_ACT field only needs to be written to when using a DSI display.
Let's move that setup to our DSI branch to clear a bit the common path.

Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/7a93436f97666a2aa025686ef3ff3606de4bec67.1590594512.git-series.maxime@cerno.tech
drivers/gpu/drm/vc4/vc4_crtc.c

index be102e7..2913140 100644 (file)
@@ -344,7 +344,8 @@ static void vc4_crtc_config_pv(struct drm_crtc *crtc)
                           (is_dsi ? PV_VCONTROL_DSI : 0));
        }
 
-       CRTC_WRITE(PV_HACT_ACT, mode->hdisplay * pixel_rep);
+       if (is_dsi)
+               CRTC_WRITE(PV_HACT_ACT, mode->hdisplay * pixel_rep);
 
        CRTC_WRITE(PV_CONTROL,
                   VC4_SET_FIELD(format, PV_CONTROL_FORMAT) |