projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a027f30
)
hwrng: don't double-check old_rng.
author
Rusty Russell
<rusty@rustcorp.com.au>
Mon, 8 Dec 2014 08:50:39 +0000
(16:50 +0800)
committer
Herbert Xu
<herbert@gondor.apana.org.au>
Mon, 22 Dec 2014 12:02:40 +0000
(23:02 +1100)
Interesting anti-pattern.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/core.c
patch
|
blob
|
history
diff --git
a/drivers/char/hw_random/core.c
b/drivers/char/hw_random/core.c
index
8d609a0
..
e384ee3
100644
(file)
--- a/
drivers/char/hw_random/core.c
+++ b/
drivers/char/hw_random/core.c
@@
-472,14
+472,13
@@
int hwrng_register(struct hwrng *rng)
}
old_rng = current_rng;
+ err = 0;
if (!old_rng) {
err = hwrng_init(rng);
if (err)
goto out_unlock;
set_current_rng(rng);
- }
- err = 0;
- if (!old_rng) {
+
err = register_miscdev();
if (err) {
drop_current_rng();