Report missing DAC error for cross DAC clrstack -i (#973)
authorSteve MacLean <Steve.MacLean@microsoft.com>
Thu, 2 Apr 2020 00:07:55 +0000 (20:07 -0400)
committerGitHub <noreply@github.com>
Thu, 2 Apr 2020 00:07:55 +0000 (00:07 +0000)
* Report missing DAC error for cross DAC clrstack -i

* Feedback

src/SOS/Strike/strike.cpp

index 091a42e83b1716e52a2e202d2d9d8518d6fd3ea1..8bbe15f0641dad9c199bf0103d9dcf0e87bf6ce4 100644 (file)
@@ -13311,7 +13311,11 @@ public:
         HRESULT Status;
 
         ICorDebugProcess* pCorDebugProcess;
-        IfFailRet(g_pRuntime->GetCorDebugInterface(&pCorDebugProcess));
+        if (FAILED(Status = g_pRuntime->GetCorDebugInterface(&pCorDebugProcess)))
+        {
+            ExtOut("\n" SOSPrefix "clrstack -i is unsupported on this target.\nThe ICorDebug interface cannot be constructed.\n\n");
+            return Status;
+        }
 
         ExtOut("\n\n\nDumping managed stack and managed variables using ICorDebug.\n");
         ExtOut("=============================================================================\n");