fuse: clean up aborted

The only caller that needs fc->aborted set is fuse_conn_abort_write().
Setting fc->aborted is now racy (fuse_abort_conn() may already be in
progress or finished) but there's no reason to care.

Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>

diff --git a/fs/fuse/control.c b/fs/fuse/control.c
index 989df5a..fe80bea 100644 (file)
--- a/fs/fuse/control.c
+++ b/fs/fuse/control.c
@@ -35,7 +35,9 @@ static ssize_t fuse_conn_abort_write(struct file *file, const char __user *buf,
 {
        struct fuse_conn *fc = fuse_ctl_file_conn_get(file);
        if (fc) {
-               fuse_abort_conn(fc, true);
+               if (fc->abort_err)
+                       fc->aborted = true;
+               fuse_abort_conn(fc);
                fuse_conn_put(fc);
        }
        return count;

diff --git a/fs/fuse/cuse.c b/fs/fuse/cuse.c
index d73eba5..55a26f3 100644 (file)
--- a/fs/fuse/cuse.c
+++ b/fs/fuse/cuse.c
@@ -408,7 +408,7 @@ err_unlock:
 err_region:
        unregister_chrdev_region(devt, 1);
 err:
-       fuse_abort_conn(fc, false);
+       fuse_abort_conn(fc);
        goto out;
 }
 
@@ -587,7 +587,7 @@ static ssize_t cuse_class_abort_store(struct device *dev,
 {
        struct cuse_conn *cc = dev_get_drvdata(dev);
 
-       fuse_abort_conn(&cc->fc, false);
+       fuse_abort_conn(&cc->fc);
        return count;
 }
 static DEVICE_ATTR(abort, 0200, NULL, cuse_class_abort_store);

diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
index 5a73094..8a63e52 100644 (file)
--- a/fs/fuse/dev.c
+++ b/fs/fuse/dev.c
@@ -1330,7 +1330,7 @@ static ssize_t fuse_dev_do_read(struct fuse_dev *fud, struct file *file,
                goto err_unlock;
 
        if (!fiq->connected) {
-               err = (fc->aborted && fc->abort_err) ? -ECONNABORTED : -ENODEV;
+               err = fc->aborted ? -ECONNABORTED : -ENODEV;
                goto err_unlock;
        }
 
@@ -1377,7 +1377,7 @@ static ssize_t fuse_dev_do_read(struct fuse_dev *fud, struct file *file,
        spin_lock(&fpq->lock);
        clear_bit(FR_LOCKED, &req->flags);
        if (!fpq->connected) {
-               err = (fc->aborted && fc->abort_err) ? -ECONNABORTED : -ENODEV;
+               err = fc->aborted ? -ECONNABORTED : -ENODEV;
                goto out_end;
        }
        if (err) {
@@ -2177,7 +2177,7 @@ static void end_polls(struct fuse_conn *fc)
  * is OK, the request will in that case be removed from the list before we touch
  * it.
  */
-void fuse_abort_conn(struct fuse_conn *fc, bool is_abort)
+void fuse_abort_conn(struct fuse_conn *fc)
 {
        struct fuse_iqueue *fiq = &fc->iq;
 
@@ -2193,7 +2193,6 @@ void fuse_abort_conn(struct fuse_conn *fc, bool is_abort)
                fc->connected = 0;
                spin_unlock(&fc->bg_lock);
 
-               fc->aborted = is_abort;
                fuse_set_initialized(fc);
                list_for_each_entry(fud, &fc->devices, entry) {
                        struct fuse_pqueue *fpq = &fud->pq;
@@ -2271,7 +2270,7 @@ int fuse_dev_release(struct inode *inode, struct file *file)
                /* Are we the last open device? */
                if (atomic_dec_and_test(&fc->dev_count)) {
                        WARN_ON(fc->iq.fasync != NULL);
-                       fuse_abort_conn(fc, false);
+                       fuse_abort_conn(fc);
                }
                fuse_dev_free(fud);
        }

diff --git a/fs/fuse/fuse_i.h b/fs/fuse/fuse_i.h
index 4fdd098..b1ac587 100644 (file)
--- a/fs/fuse/fuse_i.h
+++ b/fs/fuse/fuse_i.h
@@ -947,7 +947,7 @@ void fuse_request_send_background(struct fuse_conn *fc, struct fuse_req *req);
 bool fuse_request_queue_background(struct fuse_conn *fc, struct fuse_req *req);
 
 /* Abort all requests */
-void fuse_abort_conn(struct fuse_conn *fc, bool is_abort);
+void fuse_abort_conn(struct fuse_conn *fc);
 void fuse_wait_aborted(struct fuse_conn *fc);
 
 /**

diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
index 3d1a63e..11aac2f 100644 (file)
--- a/fs/fuse/inode.c
+++ b/fs/fuse/inode.c
@@ -379,7 +379,7 @@ void fuse_unlock_inode(struct inode *inode, bool locked)
 
 static void fuse_umount_begin(struct super_block *sb)
 {
-       fuse_abort_conn(get_fuse_conn_super(sb), false);
+       fuse_abort_conn(get_fuse_conn_super(sb));
 }
 
 static void fuse_send_destroy(struct fuse_conn *fc)
@@ -1245,7 +1245,7 @@ static void fuse_sb_destroy(struct super_block *sb)
        if (fc) {
                fuse_send_destroy(fc);
 
-               fuse_abort_conn(fc, false);
+               fuse_abort_conn(fc);
                fuse_wait_aborted(fc);
 
                down_write(&fc->killsb);