resolve format-truncation build warning 62/221062/1 accepted/tizen/unified/20191230.050142 accepted/tizen/unified/20191230.120958 submit/tizen/20191227.093222 submit/tizen/20191229.211130
authorJongmin Lee <jm105.lee@samsung.com>
Fri, 27 Dec 2019 01:31:07 +0000 (10:31 +0900)
committerJongmin Lee <jm105.lee@samsung.com>
Fri, 27 Dec 2019 01:31:07 +0000 (10:31 +0900)
Because of Werror introduced by language rules strincting in gcc9,
it results build errors when compiling  with gcc9.

Change-Id: I9745918a71a17161e65b0aee3f9fb1efd08afb88

src/efl_extension_config.c
src/wearable/circle/efl_extension_circle_object_datetime.c
src/wearable/circle/efl_extension_circle_object_spinner.c

index 75adbe3adbc7f3492b27492c4fe3c467ac43c985..1e1a25c3e66ad223dd8eb64678eaa953df49b002 100644 (file)
@@ -102,8 +102,9 @@ eext_config_font_set(char *name, int size)
 
         bzero(&server_addr, sizeof(server_addr));
         server_addr.sun_family = AF_UNIX;
-        snprintf(server_addr.sun_path, sizeof(server_addr.sun_path), "%s",
-                 sock_file);
+        if (snprintf(server_addr.sun_path, sizeof(server_addr.sun_path), "%s",
+                 sock_file) < 0)
+          WRN("text are truncated (%s)", server_addr.sun_path);
 
         r = connect(fd, (struct sockaddr *)&server_addr, sizeof(server_addr));
         if (r != 0)
index 112636201b449266cb0577c65b25111bf70d1993..ec07916953331f07ff26599ee26a5e31484bd8b9 100755 (executable)
@@ -800,6 +800,7 @@ _accessibility_item_name_cb(void *data, Evas_Object *obj)
    Eext_Circle_Object *circle_obj = (Eext_Circle_Object *)data;
    Evas_Object *datetime = circle_obj->widget_object;
    struct tm t;
+   int ret = 0;
 
    Elm_Datetime_Field_Type field_type = (Elm_Datetime_Field_Type)evas_object_data_get(obj, "_field_type");
 
@@ -812,7 +813,7 @@ _accessibility_item_name_cb(void *data, Evas_Object *obj)
         case ELM_DATETIME_DATE:
            snprintf(buf_unit, sizeof(buf_unit), _("IDS_COM_BODY_DAY"));
            _accessibility_item_make_trait(buf_trait, buf_unit, sizeof(buf_trait));
-           snprintf(buf, sizeof(buf), "%2.0f %s %s",(double)t.tm_mday, buf_unit, buf_trait);
+           ret = snprintf(buf, sizeof(buf), "%2.0f %s %s",(double)t.tm_mday, buf_unit, buf_trait);
            break;
         case ELM_DATETIME_MONTH:
            if (t.tm_mon == 0)
@@ -841,12 +842,12 @@ _accessibility_item_name_cb(void *data, Evas_Object *obj)
               snprintf(buf_month, sizeof(buf_month), _("IDS_COM_BODY_DECEMBER"));
            snprintf(buf_unit, sizeof(buf_unit), _("IDS_COM_BODY_MONTH"));
            _accessibility_item_make_trait(buf_trait, buf_unit, sizeof(buf_trait));
-           snprintf(buf, sizeof(buf), "%s %s %s",buf_month, buf_unit, buf_trait);
+           ret = snprintf(buf, sizeof(buf), "%s %s %s",buf_month, buf_unit, buf_trait);
            break;
         case ELM_DATETIME_YEAR:
            snprintf(buf_unit, sizeof(buf_unit), _("IDS_COM_BODY_YEAR"));
            _accessibility_item_make_trait(buf_trait, buf_unit, sizeof(buf_trait));
-           snprintf(buf, sizeof(buf), "%4.0f %s %s",(double)t.tm_year + (double)1900.0f, buf_unit, buf_trait);
+           ret = snprintf(buf, sizeof(buf), "%4.0f %s %s",(double)t.tm_year + (double)1900.0f, buf_unit, buf_trait);
            break;
         case ELM_DATETIME_AMPM:
            snprintf(buf_trait, sizeof(buf_trait), _("WDS_TTS_TBBODY_DOUBLE_TAP_TO_CHANGE"));
@@ -854,20 +855,23 @@ _accessibility_item_name_cb(void *data, Evas_Object *obj)
               snprintf(buf_unit, sizeof(buf_unit), _("IDS_COM_BODY_AM"));
            else
               snprintf(buf_unit, sizeof(buf_unit), _("IDS_COM_BODY_PM"));
-           snprintf(buf, sizeof(buf), "%s %s",buf_unit, buf_trait);
+           ret = snprintf(buf, sizeof(buf), "%s %s",buf_unit, buf_trait);
            break;
         case ELM_DATETIME_HOUR:
            snprintf(buf_unit, sizeof(buf_unit), _("IDS_COM_BODY_HOUR"));
            _accessibility_item_make_trait(buf_trait, buf_unit, sizeof(buf_trait));
-           snprintf(buf, sizeof(buf), "%2.0f %s %s",(double)t.tm_hour, buf_unit, buf_trait);
+           ret = snprintf(buf, sizeof(buf), "%2.0f %s %s",(double)t.tm_hour, buf_unit, buf_trait);
            break;
         case ELM_DATETIME_MINUTE:
            snprintf(buf_unit, sizeof(buf_unit), _("IDS_COM_BODY_MINUTE"));
            _accessibility_item_make_trait(buf_trait, buf_unit, sizeof(buf_trait));
-           snprintf(buf, sizeof(buf), "%2.0f %s %s",(double)t.tm_min, buf_unit, buf_trait);
+           ret = snprintf(buf, sizeof(buf), "%2.0f %s %s",(double)t.tm_min, buf_unit, buf_trait);
            break;
      }
 
+   if (ret < 0)
+     WRN("text are truncated (%s)", buf);
+
    return strdup(buf);
 
 }
index b4fdf91eb8b3e558eac1245e20a6676bb6262b22..a4930aae1af745704089c40069d30b8b718f496f 100644 (file)
@@ -533,6 +533,7 @@ _accessible_description_cb(void *data, Evas_Object *obj)
    const char *buf_val = NULL;
    const char *buf_unit = NULL;
    const char *format;
+   int ret = 0;
 
    Evas_Object *btn = elm_object_part_content_get(circle_obj->widget_object, "elm.swallow.text_button");
 
@@ -546,19 +547,23 @@ _accessible_description_cb(void *data, Evas_Object *obj)
         format = _("WDS_TTS_TBBODY_ROTATE_BEZEL_TO_ADJUST_PS");
         snprintf(buf_desc, sizeof(buf_desc), format, buf_unit);
         if(buf_val)
-           snprintf(buf, sizeof(buf), "%s %s %s",buf_val, buf_unit, buf_desc);
+           ret = snprintf(buf, sizeof(buf), "%s %s %s",buf_val, buf_unit, buf_desc);
         else
-           snprintf(buf, sizeof(buf), "%.0f %s %s",val, buf_unit, buf_desc);
+           ret = snprintf(buf, sizeof(buf), "%.0f %s %s",val, buf_unit, buf_desc);
      }
    else
      {
         format = _("WDS_TTS_TBBODY_ROTATE_BEZEL_TO_ADJUST_PS");
         snprintf(buf_desc, sizeof(buf_desc), format, "");
         if(buf_val)
-           snprintf(buf, sizeof(buf), "%s %s",buf_val, buf_desc);
+           ret = snprintf(buf, sizeof(buf), "%s %s",buf_val, buf_desc);
         else
-           snprintf(buf, sizeof(buf), "%.0f %s",val, buf_desc);
+           ret = snprintf(buf, sizeof(buf), "%.0f %s",val, buf_desc);
      }
+
+   if (ret < 0)
+     WRN("text are truncated (%s)", buf);
+
    return strdup(buf);
 }
 static void