gst/gstbin.c (gst_bin_remove_func): Wim claims I can remove this state_broadcast...

Original commit message from CVS:
2005-11-21  Andy Wingo  <wingo@pobox.com>

* gst/gstbin.c (gst_bin_remove_func): Wim claims I can remove this
state_broadcast call.

diff --git a/ChangeLog b/ChangeLog
index ff48569..5826964 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2005-11-21  Andy Wingo  <wingo@pobox.com>
 
+       * gst/gstbin.c (gst_bin_remove_func): Wim claims I can remove this
+       state_broadcast call.
+
        * gst/gstsegment.c (gst_segment_init): Initialize abs_rate.
 
 2005-11-21  Julien MOUTTE  <julien@moutte.net>

diff --git a/gst/gstbin.c b/gst/gstbin.c
index f2577b9..3235954 100644 (file)
--- a/gst/gstbin.c
+++ b/gst/gstbin.c
@@ -892,14 +892,6 @@ gst_bin_remove_func (GstBin * bin, GstElement * element)
 
   gst_element_set_bus (element, NULL);
 
-  /* unlock any waiters for the state change. It is possible that
-   * we are waiting for an ASYNC state change on this element. The
-   * element cannot be added to another bin yet as it is not yet
-   * unparented. */
-  GST_LOCK (element);
-  GST_STATE_BROADCAST (element);
-  GST_UNLOCK (element);
-
   /* we ref here because after the _unparent() the element can be disposed
    * and we still need it to reset the UNPARENTING flag and fire a signal. */
   gst_object_ref (element);