libceph: SOCK_CLOSED is a flag, not a state
authorAlex Elder <elder@inktank.com>
Thu, 21 Jun 2012 02:53:53 +0000 (21:53 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 26 Nov 2012 19:38:27 +0000 (11:38 -0800)
(cherry picked from commit a8d00e3cdef4c1c4f194414b72b24cd995439a05)

The following commit changed it so SOCK_CLOSED bit was stored in
a connection's new "flags" field rather than its "state" field.

    libceph: start separating connection flags from state
    commit 928443cd

That bit is used in con_close_socket() to protect against setting an
error message more than once in the socket event handler function.

Unfortunately, the field being operated on in that function was not
updated to be "flags" as it should have been.  This fixes that
error.

Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ceph/messenger.c

index f0499fe069a54f0213521d82070b6e1419b6bff9..edcf5eb22b496467476691cbe0ae7a258c5b02e6 100644 (file)
@@ -397,11 +397,11 @@ static int con_close_socket(struct ceph_connection *con)
        dout("con_close_socket on %p sock %p\n", con, con->sock);
        if (!con->sock)
                return 0;
-       set_bit(SOCK_CLOSED, &con->state);
+       set_bit(SOCK_CLOSED, &con->flags);
        rc = con->sock->ops->shutdown(con->sock, SHUT_RDWR);
        sock_release(con->sock);
        con->sock = NULL;
-       clear_bit(SOCK_CLOSED, &con->state);
+       clear_bit(SOCK_CLOSED, &con->flags);
        con_sock_state_closed(con);
        return rc;
 }