don't generate public setter for construct-only properties, fixes bug

2008-01-18  Juerg Billeter  <j@bitron.ch>

	* gobject/valaccodegenerator.vala: don't generate public setter for
	  construct-only properties, fixes bug 479062

svn path=/trunk/; revision=854

diff --git a/ChangeLog b/ChangeLog
index ab97e3a..c2abda2 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2008-01-18  Jürg Billeter  <j@bitron.ch>
 
+       * gobject/valaccodegenerator.vala: don't generate public setter for
+         construct-only properties, fixes bug 479062
+
+2008-01-18  Jürg Billeter  <j@bitron.ch>
+
        * vala/scanner.l, vala/parser.y: support pointers as generic type
          arguments
 

diff --git a/gobject/valaccodegenerator.vala b/gobject/valaccodegenerator.vala
index 453e0e2..bea94ad 100644 (file)
--- a/gobject/valaccodegenerator.vala
+++ b/gobject/valaccodegenerator.vala
@@ -573,7 +573,8 @@ public class Vala.CCodeGenerator : CodeGenerator {
                                function.add_parameter (cvalueparam);
                        }
                        
-                       if (!prop.is_internal_symbol ()) {
+                       if (!prop.is_internal_symbol () && (acc.readable || acc.writable)) {
+                               // accessor function should be public if the property is a public symbol and it's not a construct-only setter
                                header_type_member_declaration.append (function.copy ());
                        } else {
                                function.modifiers |= CCodeModifiers.STATIC;
@@ -656,7 +657,8 @@ public class Vala.CCodeGenerator : CodeGenerator {
                        }
 
                        if (!is_virtual) {
-                               if (!prop.is_internal_symbol ()) {
+                               if (!prop.is_internal_symbol () && (acc.readable || acc.writable)) {
+                                       // accessor function should be public if the property is a public symbol and it's not a construct-only setter
                                        header_type_member_declaration.append (function.copy ());
                                } else {
                                        function.modifiers |= CCodeModifiers.STATIC;