1. It works when the DALI_PARTIAL_UPDATE_AVAILABLE environment variable is set.
Change-Id: Ibfed04cc509e7935de4aa131fcf385a15b019606
mDataRetentionPolicy,
Integration::RenderToFrameBuffer::FALSE,
Integration::DepthBufferAvailable::TRUE,
- Integration::StencilBufferAvailable::TRUE );
+ Integration::StencilBufferAvailable::TRUE,
+ Integration::PartialUpdateAvailable::FALSE );
mCore->ContextCreated();
return mBackgroundColor;
}
+Rect<int32_t> TestRenderSurface::SetDamagedRect( const Rect<int32_t>& damagedRectArray )
+{
+ return damagedRectArray;
+}
+
+int32_t TestRenderSurface::GetBufferAge()
+{
+ return 0;
+}
+
} // Namespace dali
*/
virtual Vector4 GetBackgroundColor();
+ /**
+ * @copydoc Dali::Integration::RenderSurface::SetDamagedRect
+ */
+ virtual Rect<int32_t> SetDamagedRect( const Rect<int32_t>& damagedRectArray );
+
+ /**
+ * @copydoc Dali::Integration::RenderSurface::GetBufferAge
+ */
+ virtual int32_t GetBufferAge();
+
private:
/**
*/
virtual Integration::StencilBufferAvailable GetStencilBufferRequired() = 0;
+ /**
+ * @brief Sets currentframe updated/damaged rects
+ */
+ virtual Rect<int32_t> SetDamagedRect( const Rect<int32_t>& damagedRect ) = 0;
+
+ /**
+ * @brief Gets buffer age
+ */
+ virtual int32_t GetBufferAge() = 0;
+
public:
void SetAdaptor( Dali::Internal::Adaptor::AdaptorInternalServices& adaptor )
dataRetentionPolicy ,
( 0u != mEnvironmentOptions->GetRenderToFboInterval() ) ? Integration::RenderToFrameBuffer::TRUE : Integration::RenderToFrameBuffer::FALSE,
mGraphics->GetDepthBufferRequired(),
- mGraphics->GetStencilBufferRequired() );
+ mGraphics->GetStencilBufferRequired(),
+ mGraphics->PartialUpdateAvailable() );
defaultWindow->SetAdaptor( Get() );
*/
GraphicsInterface()
: mDepthBufferRequired( Integration::DepthBufferAvailable::FALSE ),
- mStencilBufferRequired( Integration::StencilBufferAvailable::FALSE )
+ mStencilBufferRequired( Integration::StencilBufferAvailable::FALSE ),
+ mPartialUpdateAvailable( Integration::PartialUpdateAvailable::FALSE )
{
};
return mStencilBufferRequired;
};
+ /**
+ * Get whether the partial update is available
+ * @return TRUE if the partial update is available
+ */
+ Integration::PartialUpdateAvailable PartialUpdateAvailable()
+ {
+ return mPartialUpdateAvailable;
+ };
+
protected:
/**
* Virtual protected destructor - no deletion through this interface
Integration::DepthBufferAvailable mDepthBufferRequired; ///< Whether the depth buffer is required
Integration::StencilBufferAvailable mStencilBufferRequired; ///< Whether the stencil buffer is required
+ Integration::PartialUpdateAvailable mPartialUpdateAvailable; ///Whether the partial update is available
};
} // Adaptor
mDepthBufferRequired = static_cast< Integration::DepthBufferAvailable >( environmentOptions->DepthBufferRequired() );
mStencilBufferRequired = static_cast< Integration::StencilBufferAvailable >( environmentOptions->StencilBufferRequired() );
+ mPartialUpdateAvailable = static_cast< Integration::PartialUpdateAvailable >( environmentOptions->PartialUpdateAvailable() );
mMultiSamplingLevel = environmentOptions->GetMultiSamplingLevel();
EglInterface* EglGraphics::Create()
{
- mEglImplementation = Utils::MakeUnique< EglImplementation >( mMultiSamplingLevel, mDepthBufferRequired, mStencilBufferRequired );
+ mEglImplementation = Utils::MakeUnique< EglImplementation >( mMultiSamplingLevel, mDepthBufferRequired, mStencilBufferRequired, mPartialUpdateAvailable );
mEglImageExtensions = Utils::MakeUnique< EglImageExtensions >( mEglImplementation.get() );
mEglSync->Initialize( mEglImplementation.get() ); // The sync impl needs the EglDisplay
namespace
{
- const uint32_t CHECK_EXTENSION_NUMBER = 2;
+ const uint32_t CHECK_EXTENSION_NUMBER = 3;
const std::string EGL_KHR_SURFACELESS_CONTEXT = "EGL_KHR_surfaceless_context";
const std::string EGL_KHR_CREATE_CONTEXT = "EGL_KHR_create_context";
+ const std::string EGL_KHR_PARTIAL_UPDATE = "EGL_KHR_partial_update";
}
namespace Dali
EglImplementation::EglImplementation( int multiSamplingLevel,
Integration::DepthBufferAvailable depthBufferRequired,
- Integration::StencilBufferAvailable stencilBufferRequired )
+ Integration::StencilBufferAvailable stencilBufferRequired,
+ Integration::PartialUpdateAvailable partialUpdateAvailable )
: mContextAttribs(),
mEglNativeDisplay( 0 ),
mEglNativeWindow( 0 ),
mCurrentEglContext( EGL_NO_CONTEXT ),
mMultiSamplingLevel( multiSamplingLevel ),
mGlesVersion( 30 ),
+ mDamagedRectArray( 0 ),
mColorDepth( COLOR_DEPTH_24 ),
mGlesInitialized( false ),
mIsOwnSurface( true ),
mStencilBufferRequired( stencilBufferRequired == Integration::StencilBufferAvailable::TRUE ),
mIsSurfacelessContextSupported( false ),
mIsKhrCreateContextSupported( false ),
- mIsFirstFrameAfterResume( false )
+ mIsFirstFrameAfterResume( false ),
+ mIsKhrPartialUpdateSupported( false ),
+ mPartialUpdateAvailable( partialUpdateAvailable == Integration::PartialUpdateAvailable::TRUE )
{
+ if( mPartialUpdateAvailable )
+ {
+ mEglSetDamageRegionKHR = reinterpret_cast< PFNEGLSETDAMAGEREGIONKHRPROC >( eglGetProcAddress( "eglSetDamageRegionKHR" ) );
+ mSwapBuffersWithDamage = reinterpret_cast< PFNEGLSWAPBUFFERSWITHDAMAGEEXTPROC >( eglGetProcAddress( "eglSwapBuffersWithDamageEXT" ) );
+ if( !mEglSetDamageRegionKHR || !mSwapBuffersWithDamage )
+ {
+ mPartialUpdateAvailable = false;
+ DALI_LOG_ERROR("Initialization of partial update failed.\n");
+ }
+ else
+ {
+ DALI_LOG_RELEASE_INFO("Initialization of partial update success!\n");
+ }
+ }
}
EglImplementation::~EglImplementation()
mIsKhrCreateContextSupported = true;
extensionCheckCount++;
}
+ if( currentExtension == EGL_KHR_PARTIAL_UPDATE )
+ {
+ mIsKhrPartialUpdateSupported = true;
+ extensionCheckCount++;
+ }
+ }
+
+ if( !mIsKhrPartialUpdateSupported )
+ {
+ mPartialUpdateAvailable = false;
}
// We want to display this information all the time, so use the LogMessage directly
return mGlesInitialized;
}
+
+const char* GetEglErrorString(EGLint error)
+{
+ switch(error)
+ {
+ case EGL_SUCCESS: return "No error";
+ case EGL_NOT_INITIALIZED: return "EGL not initialized or failed to initialize";
+ case EGL_BAD_ACCESS: return "Resource inaccessible";
+ case EGL_BAD_ALLOC: return "Cannot allocate resources";
+ case EGL_BAD_ATTRIBUTE: return "Unrecognized attribute or attribute value";
+ case EGL_BAD_CONTEXT: return "Invalid EGL context";
+ case EGL_BAD_CONFIG: return "Invalid EGL frame buffer configuration";
+ case EGL_BAD_CURRENT_SURFACE: return "Current surface is no longer valid";
+ case EGL_BAD_DISPLAY: return "Invalid EGL display";
+ case EGL_BAD_SURFACE: return "Invalid surface";
+ case EGL_BAD_MATCH: return "Inconsistent arguments";
+ case EGL_BAD_PARAMETER: return "Invalid argument";
+ case EGL_BAD_NATIVE_PIXMAP: return "Invalid native pixmap";
+ case EGL_BAD_NATIVE_WINDOW: return "Invalid native window";
+ case EGL_CONTEXT_LOST: return "Context lost";
+ }
+ return "Unknown error ";
+}
+
+
void EglImplementation::SwapBuffers( EGLSurface& eglSurface )
{
if ( eglSurface != EGL_NO_SURFACE ) // skip if using surfaceless context
DALI_LOG_RELEASE_INFO( "EglImplementation::SwapBuffers: First SwapBuffers call.\n" );
mIsFirstFrameAfterResume = false;
}
- eglSwapBuffers( mEglDisplay, eglSurface );
+ if( mPartialUpdateAvailable && mSwapBuffersWithDamage )
+ {
+ mSwapBuffersWithDamage( mEglDisplay, eglSurface, &mDamagedRectArray[0], mDamagedRectArray.size()/4 );
+ }
+ else
+ {
+ eglSwapBuffers( mEglDisplay, eglSurface );
+ }
+ }
+}
+
+
+int EglImplementation::GetBufferAge( EGLSurface& eglSurface )
+{
+ int bufferAge = 0;
+ if ( eglSurface != EGL_NO_SURFACE && mIsKhrPartialUpdateSupported )
+ {
+ if( !eglQuerySurface(mEglDisplay, eglSurface, EGL_BUFFER_AGE_KHR, &bufferAge) )
+ {
+ DALI_LOG_ERROR("EglImplementation::GetBufferAge() eglQuerySurface %s ", GetEglErrorString(eglGetError()) );
+ }
+ }
+ return bufferAge;
+}
+
+void EglImplementation::SetDamagedRect( std::vector<int> damagedRectArray, EGLSurface& eglSurface )
+{
+ mDamagedRectArray = damagedRectArray;
+ if ( eglSurface != EGL_NO_SURFACE && mPartialUpdateAvailable && mEglSetDamageRegionKHR )
+ {
+ if( !mEglSetDamageRegionKHR( mEglDisplay, eglSurface, &damagedRectArray[0], damagedRectArray.size() / 4 ) )
+ {
+ DALI_LOG_ERROR("EglImplementation::mEglSetDamageRegionKHR() error %s ", GetEglErrorString(eglGetError()) );
+ }
}
}
* @param[in] multiSamplingLevel The Multi-sampling level required
* @param[in] depthBufferRequired Whether the depth buffer is required
* @param[in] stencilBufferRequired Whether the stencil buffer is required
+ * @param[in] partialUpdateAvailable Whether the partial update is available
*/
EglImplementation( int multiSamplingLevel,
Integration::DepthBufferAvailable depthBufferRequired,
- Integration::StencilBufferAvailable stencilBufferRequired );
+ Integration::StencilBufferAvailable stencilBufferRequired,
+ Integration::PartialUpdateAvailable partialUpdateAvailable );
/**
* Destructor
*/
virtual void SwapBuffers( EGLSurface& eglSurface );
+ /**
+ * Get current buffer age
+ */
+ virtual int GetBufferAge( EGLSurface& eglSurface );
+
+ /**
+ * Set Damaged rect for Partial update
+ */
+ virtual void SetDamagedRect( std::vector<int> damagedRectArray, EGLSurface& eglSurface );
+
/**
* Performs an OpenGL copy buffers command
*/
int32_t mMultiSamplingLevel;
int32_t mGlesVersion;
+ std::vector<int> mDamagedRectArray;
ColorDepth mColorDepth;
bool mIsKhrCreateContextSupported;
bool mIsFirstFrameAfterResume;
+ bool mIsKhrPartialUpdateSupported;
+ bool mPartialUpdateAvailable;
+
+ PFNEGLSETDAMAGEREGIONKHRPROC mEglSetDamageRegionKHR;
+ PFNEGLSWAPBUFFERSWITHDAMAGEEXTPROC mSwapBuffersWithDamage;
};
} // namespace Adaptor
mThreadingMode( ThreadingMode::COMBINED_UPDATE_RENDER ),
mGlesCallAccumulate( false ),
mDepthBufferRequired( DEFAULT_DEPTH_BUFFER_REQUIRED_SETTING ),
- mStencilBufferRequired( DEFAULT_STENCIL_BUFFER_REQUIRED_SETTING )
+ mStencilBufferRequired( DEFAULT_STENCIL_BUFFER_REQUIRED_SETTING ),
+ mPartialUpdateAvailable( false )
{
ParseEnvironmentOptions();
}
return mStencilBufferRequired;
}
+bool EnvironmentOptions::PartialUpdateAvailable() const
+{
+ return mPartialUpdateAvailable;
+}
+
void EnvironmentOptions::ParseEnvironmentOptions()
{
// get logging options
mStencilBufferRequired = false;
}
}
+
+ int partialUpdateRequired( -1 );
+ if( GetIntegerEnvironmentVariable( DALI_ENV_PARTIAL_UPDATE_AVAILABLE, partialUpdateRequired ) )
+ {
+ if( partialUpdateRequired > 0 )
+ {
+ mPartialUpdateAvailable = true;
+ }
+ }
}
} // Adaptor
*/
bool StencilBufferRequired() const;
+ /**
+ * @return whether the partial update is available.
+ */
+ bool PartialUpdateAvailable() const;
+
/// Deleted copy constructor.
EnvironmentOptions( const EnvironmentOptions& ) = delete;
bool mGlesCallAccumulate; ///< Whether or not to accumulate gles call statistics
bool mDepthBufferRequired; ///< Whether the depth buffer is required
bool mStencilBufferRequired; ///< Whether the stencil buffer is required
+ bool mPartialUpdateAvailable; ///< whether the partial update is available
std::unique_ptr<TraceManager> mTraceManager; ///< TraceManager
};
#define DALI_ENV_DPI_VERTICAL "DALI_DPI_VERTICAL"
+#define DALI_ENV_PARTIAL_UPDATE_AVAILABLE "DALI_PARTIAL_UPDATE_AVAILABLE"
+
} // namespace Adaptor
} // namespace Internal
{
const int MINIMUM_DIMENSION_CHANGE( 1 ); ///< Minimum change for window to be considered to have moved
+const int TILE_SIZE = 16u; ///< Unit of tile size at GPU driver
#if defined(DEBUG_ENABLED)
Debug::Filter* gWindowRenderSurfaceLogFilter = Debug::Filter::New(Debug::Verbose, false, "LOG_WINDOW_RENDER_SURFACE");
mOutputTransformedSignal(),
mRotationAngle( 0 ),
mScreenRotationAngle( 0 ),
+ mBufferAge( 0 ),
+ mPreBufferAge( 0 ),
mOwnSurface( false ),
mRotationSupported( false ),
mRotationFinished( true ),
mScreenRotationFinished( true ),
mResizeFinished( true ),
mDpiHorizontal( 0 ),
- mDpiVertical( 0 )
+ mDpiVertical( 0 ),
+ mPreDamagedRect()
{
DALI_LOG_INFO( gWindowRenderSurfaceLogFilter, Debug::Verbose, "Creating Window\n" );
Initialize( surface );
return true;
}
+std::vector<int32_t> WindowRenderSurface::MergeRect( const Rect<int32_t>& damagedRect, int bufferAge )
+{
+ std::vector<int32_t> mergedRectArray;
+ // merge bounding
+ int dx1 = mPositionSize.width, dx2 = 0, dy1 = mPositionSize.height, dy2 = 0;
+ int checkWidth = mPositionSize.width - TILE_SIZE;
+ int checkHeight = mPositionSize.height - TILE_SIZE;
+
+ dx1 = std::min( damagedRect.x, dx1 );
+ dx2 = std::max( damagedRect.x + damagedRect.width, dx2);
+ dy1 = std::min( damagedRect.y, dy1 );
+ dy2 = std::max( damagedRect.y + damagedRect.height, dy2 );
+
+ for( int j = 0; j <= bufferAge; j++ )
+ {
+ if( !mPreDamagedRect[j].IsEmpty() )
+ {
+ dx1 = std::min( mPreDamagedRect[j].x, dx1 );
+ dx2 = std::max( mPreDamagedRect[j].x + mPreDamagedRect[j].width, dx2);
+ dy1 = std::min( mPreDamagedRect[j].y, dy1 );
+ dy2 = std::max( mPreDamagedRect[j].y + mPreDamagedRect[j].height, dy2 );
+
+ if( dx1 < TILE_SIZE && dx2 > checkWidth && dy1 < TILE_SIZE && dy2 > checkHeight )
+ {
+ dx1 = 0, dx2 = mPositionSize.width, dy1 = 0, dy2 = mPositionSize.height;
+ break;
+ }
+ }
+ }
+
+ dx1 = TILE_SIZE * (dx1 / TILE_SIZE);
+ dy1 = TILE_SIZE * (dy1 / TILE_SIZE);
+ dx2 = TILE_SIZE * ((dx2 + TILE_SIZE - 1) / TILE_SIZE);
+ dy2 = TILE_SIZE * ((dy2 + TILE_SIZE - 1) / TILE_SIZE);
+
+ mergedRectArray.push_back( dx1 );
+ mergedRectArray.push_back( dy1 );
+ mergedRectArray.push_back( dx2 - dx1 );
+ mergedRectArray.push_back( dy2 - dy1 );
+
+ return mergedRectArray;
+}
+
+
+Rect<int32_t> WindowRenderSurface::SetDamagedRect( const Rect<int32_t>& damagedRect )
+{
+ auto eglGraphics = static_cast<EglGraphics *>( mGraphics );
+ std::vector<int32_t> rectArray;
+ Rect<int32_t> mergedDamagedRect;
+ if( eglGraphics )
+ {
+ Internal::Adaptor::EglImplementation& eglImpl = eglGraphics->GetEglImplementation();
+
+ rectArray = MergeRect( damagedRect, mBufferAge );
+
+ mPreDamagedRect[4] = std::move( mPreDamagedRect[3] );
+ mPreDamagedRect[3] = std::move( mPreDamagedRect[2] );
+ mPreDamagedRect[2] = std::move( mPreDamagedRect[1] );
+ mPreDamagedRect[1] = std::move( mPreDamagedRect[0] );
+ mPreDamagedRect[0] = std::move( damagedRect );
+
+ eglImpl.SetDamagedRect( rectArray, mEGLSurface );
+ }
+
+ if( !rectArray.empty() )
+ {
+ mergedDamagedRect.x = rectArray[0];
+ mergedDamagedRect.y = rectArray[1];
+ mergedDamagedRect.width = rectArray[2];
+ mergedDamagedRect.height = rectArray[3];
+ }
+
+ return mergedDamagedRect;
+}
+
+int32_t WindowRenderSurface::GetBufferAge()
+{
+ int result = mBufferAge = 0;
+ auto eglGraphics = static_cast<EglGraphics *>( mGraphics );
+ if( eglGraphics )
+ {
+ Internal::Adaptor::EglImplementation& eglImpl = eglGraphics->GetEglImplementation();
+ mBufferAge = eglImpl.GetBufferAge( mEGLSurface );;
+ result = ( mBufferAge != mPreBufferAge ) ? 0 : mBufferAge;
+ mPreBufferAge = mBufferAge;
+ }
+ return result;
+}
+
void WindowRenderSurface::PostRender( bool renderToFbo, bool replacingSurface, bool resizingSurface )
{
// Inform the gl implementation that rendering has finished before informing the surface
}
Internal::Adaptor::EglImplementation& eglImpl = eglGraphics->GetEglImplementation();
+
eglImpl.SwapBuffers( mEGLSurface );
if( mRenderNotification )
*/
virtual Integration::StencilBufferAvailable GetStencilBufferRequired() override;
+ /**
+ * @copydoc Dali::Integration::RenderSurface::SetDamagedRect()
+ */
+ virtual Rect<int32_t> SetDamagedRect( const Rect<int32_t>& damagedRectArray ) override;
+
+ /**
+ * @copydoc Dali::Integration::RenderSurface::GetBufferAge()
+ */
+ virtual int32_t GetBufferAge() override;
+
private:
/**
*/
void ProcessRotationRequest();
+ /*
+ * @brief MergeRect
+ */
+ std::vector<int32_t> MergeRect( const Rect<int32_t>& damagedRectArray, int bufferAge );
+
protected:
// Undefined
OutputSignalType mOutputTransformedSignal;
int mRotationAngle;
int mScreenRotationAngle;
+ int mBufferAge;
+ int mPreBufferAge;
bool mOwnSurface; ///< Whether we own the surface (responsible for deleting it)
bool mRotationSupported;
bool mRotationFinished;
uint32_t mDpiHorizontal;
uint32_t mDpiVertical;
+ Rect<int32_t> mPreDamagedRect[5]; ///< The GPU driver can has up to four buffers. And one is for area calculation.
}; // class WindowRenderSurface
} // namespace Adaptor
return true;
}
+Rect<int32_t> NativeRenderSurfaceEcoreWl::SetDamagedRect( const Rect<int32_t>& damagedRect )
+{
+ return damagedRect;
+}
+
+int32_t NativeRenderSurfaceEcoreWl::GetBufferAge()
+{
+ return 0;
+}
+
void NativeRenderSurfaceEcoreWl::PostRender( bool renderToFbo, bool replacingSurface, bool resizingSurface )
{
auto eglGraphics = static_cast<Internal::Adaptor::EglGraphics *>(mGraphics);
*/
virtual Integration::StencilBufferAvailable GetStencilBufferRequired() override;
+ /**
+ * @copydoc Dali::Integration::RenderSurface::SetDamagedRect()
+ */
+ virtual Rect<int32_t> SetDamagedRect( const Rect<int32_t>& damagedRect ) override;
+
+ /**
+ * @copydoc Dali::Integration::RenderSurface::GetBufferAge()
+ */
+ virtual int32_t GetBufferAge() override;
+
+
+
private:
/**
return true;
}
+Rect<int32_t> PixmapRenderSurfaceEcoreX::SetDamagedRect( const Rect<int32_t>& damagedRect )
+{
+ return damagedRect;
+}
+
+int32_t PixmapRenderSurfaceEcoreX::GetBufferAge()
+{
+ return 0;
+}
+
void PixmapRenderSurfaceEcoreX::PostRender( bool renderToFbo, bool replacingSurface, bool resizingSurface )
{
auto eglGraphics = static_cast<EglGraphics *>(mGraphics);
*/
virtual void UseExistingRenderable( unsigned int surfaceId ) override;
+ /**
+ * @copydoc Dali::Integration::RenderSurface::SetDamagedRect()
+ */
+ virtual Rect<int32_t> SetDamagedRect( const Rect<int32_t>& damagedRect ) override;
+
+ /**
+ * @copydoc Dali::Integration::RenderSurface::GetBufferAge()
+ */
+ virtual int32_t GetBufferAge() override;
+
private:
/**