mm: Remove pointless barrier() after pmdp_get_lockless()

pmdp_get_lockless() should itself imply any ordering required.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20221022114425.298833095%40infradead.org

diff --git a/mm/hmm.c b/mm/hmm.c
index 39cf50d..601a99c 100644 (file)
--- a/mm/hmm.c
+++ b/mm/hmm.c
@@ -362,7 +362,6 @@ again:
                 * values.
                 */
                pmd = pmdp_get_lockless(pmdp);
-               barrier();
                if (!pmd_devmap(pmd) && !pmd_trans_huge(pmd))
                        goto again;
 

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 88ef873..4936a88 100644 (file)
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -4041,9 +4041,6 @@ restart:
        for (i = pmd_index(start), addr = start; addr != end; i++, addr = next) {
                pmd_t val = pmdp_get_lockless(pmd + i);
 
-               /* for pmdp_get_lockless() */
-               barrier();
-
                next = pmd_addr_end(addr, end);
 
                if (!pmd_present(val) || is_huge_zero_pmd(val)) {