- Add GetUID() function to ParamChecker to get parsed UID properly.
- Change SendFail() to accept error type as parameter.
- Remove parameter of EventSignalSender constructer. and add setter functions.
Change-Id: Iedde81894c25afde769ff89a55a4725706fa6bbf
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
#include <string>
+#include "include/error_type.hh"
#include "include/request_type.hh"
namespace rsc_handler {
class EventSignalSender {
public:
- EventSignalSender(std::string pkgid, ReqType req_type);
+ EventSignalSender() : pkgid_(""), req_type_(ReqType::REQ_TYPE_UNKNOWN) {};
bool SendStart();
bool SendOK();
- bool SendFail();
+ bool SendFail(ErrorType error);
+ void SetPkgID(std::string pkgid);
+ void SetReqType(ReqType req_type);
private:
std::string pkgid_;
ParamChecker(int argc, char* argv[]);
ReqType GetRequestType();
std::string GetPkgID() const;
+ uid_t GetUID() const;
const std::list<RscPathInfo>& GetPathList() const;
bool Validate();
#include <iostream>
#include <string>
+#include "include/error_type.hh"
#include "include/request_type.hh"
namespace rsc_handler {
-EventSignalSender::EventSignalSender(std::string pkgid, ReqType req_type) :
- pkgid_(pkgid), req_type_(req_type) {}
-
bool EventSignalSender::SendStart() {
std::cout << "EventSignalSender::SendStart" << std::endl;
return true;
}
-bool SendOK() {
+bool EventSignalSender::SendOK() {
std::cout << "EventSignalSender::SendOK" << std::endl;
return true;
}
-bool SendFail() {
+bool EventSignalSender::SendFail(ErrorType error) {
std::cout << "EventSignalSender::SendFail" << std::endl;
return true;
}
+void EventSignalSender::SetPkgID(std::string pkgid) {
+ pkgid_ = pkgid;
+}
+
+void EventSignalSender::SetReqType(ReqType req_type) {
+ req_type_ = req_type;
+}
+
} // namespace rsc_handler
return pkgid_;
}
+uid_t ParamChecker::GetUID() const {
+ return uid_;
+}
+
ReqType ParamChecker::GetRequestType() {
return req_type_;
}
return false;
}
- rsc_handler::EventSignalSender signal(
- option.GetPkgID(), option.GetRequestType());
+ rsc_handler::EventSignalSender signal;
+ signal.SetPkgID(option.GetPkgID());
+ signal.SetReqType(option.GetRequestType());
rsc_handler::RequestHandlerInvoker handler(option, signal);
if (!handler.Validate()) {
EXPECT_EQ(checker.GetRequestType(), rsc_handler::ReqType::REQ_TYPE_NEW);
EXPECT_EQ(checker.GetPkgID(), "org.test.targetpkgid");
EXPECT_EQ(checker.GetPathList().size(), 1);
+ EXPECT_EQ(checker.GetUID(), 5001);
}
TEST_F(ParamCheckerTest, RemoveRsc) {
EXPECT_EQ(checker.GetRequestType(), rsc_handler::ReqType::REQ_TYPE_REMOVE);
EXPECT_EQ(checker.GetPkgID(), "org.test.targetpkgid");
EXPECT_EQ(checker.GetPathList().size(), 1);
+ EXPECT_EQ(checker.GetUID(), 5001);
}
TEST_F(ParamCheckerTest, DeleteRsc) {
EXPECT_EQ(checker.GetRequestType(), rsc_handler::ReqType::REQ_TYPE_UNINSTALL);
EXPECT_EQ(checker.GetPkgID(), "org.test.targetpkgid");
EXPECT_EQ(checker.GetPathList().size(), 0);
+ EXPECT_EQ(checker.GetUID(), 5001);
}
TEST_F(ParamCheckerTest, EmptyPkgID) {