pinctrl: gemini: Mask properly
authorLinus Walleij <linus.walleij@linaro.org>
Sun, 17 Jun 2018 23:00:48 +0000 (01:00 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 26 Jun 2018 07:51:42 +0000 (09:51 +0200)
Some logical error in the gemini pin control driver made
it not mask and write properly for the GMAC.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-gemini.c

index 8c9970a..fa7d998 100644 (file)
@@ -1696,6 +1696,7 @@ static const struct gemini_pin_group gemini_3516_pin_groups[] = {
                .name = "gmii_gmac0_grp",
                .pins = gmii_gmac0_3516_pins,
                .num_pins = ARRAY_SIZE(gmii_gmac0_3516_pins),
+               .mask = GEMINI_GMAC_IOSEL_MASK,
                .driving_mask = GENMASK(17, 16),
        },
        {
@@ -1703,6 +1704,7 @@ static const struct gemini_pin_group gemini_3516_pin_groups[] = {
                .pins = gmii_gmac1_3516_pins,
                .num_pins = ARRAY_SIZE(gmii_gmac1_3516_pins),
                /* Bring out RGMII on the GMAC1 pins */
+               .mask = GEMINI_GMAC_IOSEL_MASK,
                .value = GEMINI_GMAC_IOSEL_GMAC0_GMAC1_RGMII,
                .driving_mask = GENMASK(19, 18),
        },