wifi: mac80211: remove return value check of debugfs_create_dir()
authorYingsha Xu <ysxu@hust.edu.cn>
Wed, 19 Apr 2023 10:45:47 +0000 (18:45 +0800)
committerJohannes Berg <johannes.berg@intel.com>
Thu, 20 Apr 2023 09:46:07 +0000 (11:46 +0200)
Smatch complains that:
debugfs_hw_add() warn: 'statsd' is an error pointer or valid

Debugfs checks are generally not supposed to be checked for errors
and it is not necessary here.

Just delete the dead code.

Signed-off-by: Yingsha Xu <ysxu@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Link: https://lore.kernel.org/r/20230419104548.30124-1-ysxu@hust.edu.cn
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/debugfs.c

index dfb9f55..207f772 100644 (file)
@@ -673,10 +673,6 @@ void debugfs_hw_add(struct ieee80211_local *local)
 
        statsd = debugfs_create_dir("statistics", phyd);
 
-       /* if the dir failed, don't put all the other things into the root! */
-       if (!statsd)
-               return;
-
 #ifdef CONFIG_MAC80211_DEBUG_COUNTERS
        DEBUGFS_STATS_ADD(dot11TransmittedFragmentCount);
        DEBUGFS_STATS_ADD(dot11MulticastTransmittedFrameCount);