validate:ssim: Avoid dereferencing NULL pointer
authorThibault Saunier <tsaunier@igalia.com>
Thu, 7 May 2020 13:09:14 +0000 (09:09 -0400)
committerEdward Hervey <bilboed@bilboed.com>
Sat, 6 Jun 2020 06:00:11 +0000 (06:00 +0000)
CID 1462650

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-devtools/-/merge_requests/192>

validate/plugins/ssim/gstvalidatessim.c

index a9008b0..afad4e0 100644 (file)
@@ -302,6 +302,12 @@ _can_attach (GstValidateOverride * override, GstValidateMonitor * monitor)
 
   pad = GST_PAD (gst_validate_monitor_get_target (monitor));
   element = gst_validate_monitor_get_element (monitor);
+
+  if (!element) {
+    GST_INFO_OBJECT (monitor, "Not in an element yet, can't attach");
+    goto fail;
+  }
+
   if ((gst_validate_element_has_klass (element, "Converter") ||
           gst_validate_element_has_klass (element, "Filter") ||
           gst_validate_element_has_klass (element, "Decoder")) &&