scsi: arcmsr: Ensure getting a free ccb is done under the spin_lock
authorching Huang <ching2048@areca.com.tw>
Tue, 27 Oct 2020 03:39:13 +0000 (11:39 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 30 Oct 2020 02:10:34 +0000 (22:10 -0400)
Ensure getting a free ccb is done under the spin_lock.

Link: https://lore.kernel.org/r/f3ec374cada762149911ff35e92a68a15a7d0327.camel@areca.com.tw
Signed-off-by: ching Huang <ching2048@areca.com.tw>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/arcmsr/arcmsr_hba.c

index 7cfae1d..127fe50 100644 (file)
@@ -3162,10 +3162,12 @@ message_out:
 
 static struct CommandControlBlock *arcmsr_get_freeccb(struct AdapterControlBlock *acb)
 {
-       struct list_head *head = &acb->ccb_free_list;
+       struct list_head *head;
        struct CommandControlBlock *ccb = NULL;
        unsigned long flags;
+
        spin_lock_irqsave(&acb->ccblist_lock, flags);
+       head = &acb->ccb_free_list;
        if (!list_empty(head)) {
                ccb = list_entry(head->next, struct CommandControlBlock, list);
                list_del_init(&ccb->list);