perf tools: Use ARRAY_SIZE() instead of ad hoc equivalent, spotted by array_size...
authorGuo Zhengkui <guozhengkui@vivo.com>
Mon, 7 Mar 2022 03:39:59 +0000 (11:39 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 7 Mar 2022 17:54:54 +0000 (14:54 -0300)
Fix the following coccicheck warning:

tools/perf/util/trace-event-parse.c:209:35-36: WARNING: Use ARRAY_SIZE

ARRAY_SIZE(arr) is a macro provided in tools/include/linux/kernel.h,
which not only measures the size of the array, but also makes sure
that `arr` is really an array.

It has been tested with gcc (Debian 8.3.0-6) 8.3.0.

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20220307034008.4024-1-guozhengkui@vivo.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/trace-event-parse.c

index 9634f0a..c9c83a4 100644 (file)
@@ -206,7 +206,7 @@ unsigned long long eval_flag(const char *flag)
        if (isdigit(flag[0]))
                return strtoull(flag, NULL, 0);
 
-       for (i = 0; i < (int)(sizeof(flags)/sizeof(flags[0])); i++)
+       for (i = 0; i < (int)(ARRAY_SIZE(flags)); i++)
                if (strcmp(flags[i].name, flag) == 0)
                        return flags[i].value;