s390/vmcp: simplify vmcp_response_free()
authorHeiko Carstens <heiko.carstens@de.ibm.com>
Fri, 18 Aug 2017 06:35:33 +0000 (08:35 +0200)
committerMartin Schwidefsky <schwidefsky@de.ibm.com>
Tue, 29 Aug 2017 14:29:02 +0000 (16:29 +0200)
Get rid of the goto and "out" label within vmcp_response_free() which
I added. This just makes the code harder to read than necessary.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
drivers/s390/char/vmcp.c

index 0aa50af..7898bbc 100644 (file)
@@ -90,10 +90,9 @@ static void vmcp_response_free(struct vmcp_session *session)
                page = phys_to_page((unsigned long)session->response);
                cma_release(vmcp_cma, page, nr_pages);
                session->cma_alloc = 0;
-               goto out;
+       } else {
+               free_pages((unsigned long)session->response, order);
        }
-       free_pages((unsigned long)session->response, order);
-out:
        session->response = NULL;
 }