SUMMARY:
In this patch we put the global variable in a Csect which's SectionKind is "ReadOnlyWithRel" into Data Section.
Reviewers: hubert.reinterpretcast,jasonliu,Xiangling_L
Subscribers: wuzish, nemanjai, hiraditya
Differential Revision: https://reviews.llvm.org/D72461
if (Kind.isText())
return TextSection;
- if (Kind.isData())
+ if (Kind.isData() || Kind.isReadOnlyWithRel())
+ // TODO: We may put this under option control, because user may want to
+ // have read-only data with relocations placed into a read-only section by
+ // the compiler.
return DataSection;
// Zero initialized data must be emitted to the .data section because external
TargetLoweringObjectFileXCOFF::getStorageClassForGlobal(GV));
SectionKind GVKind = getObjFileLowering().getKindForGlobal(GV, TM);
- if ((!GVKind.isCommon() && !GVKind.isBSS() && !GVKind.isData() &&
- !GVKind.isReadOnly()) ||
+ if ((!GVKind.isGlobalWriteableData() && !GVKind.isReadOnly()) ||
GVKind.isMergeable2ByteCString() || GVKind.isMergeable4ByteCString())
report_fatal_error("Encountered a global variable kind that is "
"not supported yet.");
--- /dev/null
+; RUN: llc -verify-machineinstrs -mcpu=pwr4 -mtriple powerpc-ibm-aix-xcoff --relocation-model=pic < %s | FileCheck %s
+; RUN: llc -verify-machineinstrs -mcpu=pwr4 -mtriple powerpc64-ibm-aix-xcoff --relocation-model=pic < %s | FileCheck --check-prefix=CHECK64 %s
+
+@a = common global i32 0
+@b = constant i32* @a
+
+;CHECK: .comm a[RW],4,2
+;CHECK-NEXT: .csect .data[RW]
+;CHECK-NEXT: .globl b
+;CHECK-NEXT: .align 2
+;CHECK-NEXT: b:
+;CHECK-NEXT: .long a
+
+;CHECK64: .comm a[RW],4,2
+;CHECK64-NEXT: .csect .data[RW]
+;CHECK64-NEXT: .globl b
+;CHECK64-NEXT: .align 3
+;CHECK64-NEXT: b:
+;CHECK64-NEXT: .llong a