iio: light: tsl2772: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Sat, 29 Aug 2020 06:47:23 +0000 (08:47 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Thu, 3 Sep 2020 18:40:51 +0000 (19:40 +0100)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20200829064726.26268-15-krzk@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/light/tsl2772.c

index 7353994..d792053 100644 (file)
@@ -1776,14 +1776,8 @@ static int tsl2772_probe(struct i2c_client *clientp,
        ret = devm_regulator_bulk_get(&clientp->dev,
                                      ARRAY_SIZE(chip->supplies),
                                      chip->supplies);
-       if (ret < 0) {
-               if (ret != -EPROBE_DEFER)
-                       dev_err(&clientp->dev,
-                               "Failed to get regulators: %d\n",
-                               ret);
-
-               return ret;
-       }
+       if (ret < 0)
+               return dev_err_probe(&clientp->dev, ret, "Failed to get regulators\n");
 
        ret = regulator_bulk_enable(ARRAY_SIZE(chip->supplies), chip->supplies);
        if (ret < 0) {