Re-enable tst_QJSEngine::stringObjects test
authorPeter Varga <pvarga@inf.u-szeged.hu>
Thu, 18 Oct 2012 15:16:40 +0000 (17:16 +0200)
committerThe Qt Project <gerrit-noreply@qt-project.org>
Fri, 19 Oct 2012 08:39:21 +0000 (10:39 +0200)
Corresponding bug has been fixed in QtJSBackend thus re-enable test and
remove expected failures.

Change-Id: I72d6ce31a1c932db29dad0758e0c2654543a5b1f
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
tests/auto/qml/qjsengine/tst_qjsengine.cpp

index 7892290..87d2673 100644 (file)
@@ -1955,8 +1955,6 @@ void tst_QJSEngine::stringObjects()
 {
     // See ECMA-262 Section 15.5, "String Objects".
 
-    QSKIP("This test is temporarily skipped until fix is not landed: https://codereview.qt-project.org/#change,37284");
-
     QJSEngine eng;
     QString str("ciao");
     // in C++
@@ -1967,7 +1965,6 @@ void tst_QJSEngine::stringObjects()
             QString pname = QString::number(i);
             QVERIFY(obj.property(pname).isString());
             QCOMPARE(obj.property(pname).toString(), QString(str.at(i)));
-            QEXPECT_FAIL("", "FIXME: This is V8 issue 862. ECMA script standard 15.5.5.2 compliance.", Continue);
             QVERIFY(!obj.deleteProperty(pname));
             obj.setProperty(pname, 123);
             QVERIFY(obj.property(pname).isString());
@@ -2006,7 +2003,6 @@ void tst_QJSEngine::stringObjects()
 
         QJSValue ret5 = eng.evaluate("delete s[0]");
         QVERIFY(ret5.isBool());
-        QEXPECT_FAIL("", "FIXME: This is V8 bug, please report it! ECMA script standard 15.5.5.2", Abort);
         QVERIFY(!ret5.toBool());
 
         QJSValue ret6 = eng.evaluate("delete s[-1]");