tests:nle: Unref the bus before unrefing the pipeline
authorThibault Saunier <tsaunier@igalia.com>
Mon, 12 Aug 2019 21:37:39 +0000 (17:37 -0400)
committerThibault Saunier <tsaunier@igalia.com>
Mon, 12 Aug 2019 21:40:33 +0000 (17:40 -0400)
Aiming at fixing a rare race condition where we get:

    ../subprojects/gstreamer/libs/gst/check/gstcheck.c:1258:F:nlecomposition:test_seek_on_nested:0: nested_src0_0x1a1a310 is not destroyed, 1 refcounts left!

The idea is that there might have a remaining GstMessage
with the nested_src as `message.src` on the bus that has
yet to be processed in some conditions leading to a reference
still existing when unrefing the pipeline.

tests/check/nle/nlecomposition.c

index 71c9099..aa840b8 100644 (file)
@@ -554,9 +554,9 @@ GST_START_TEST (test_seek_on_nested)
   GST_DEBUG ("Resetted pipeline to NULL");
 
   ASSERT_OBJECT_REFCOUNT_BETWEEN (pipeline, "main pipeline", 1, 2);
-  gst_check_objects_destroyed_on_unref (pipeline, comp, nested_source, NULL);
   ASSERT_OBJECT_REFCOUNT_BETWEEN (bus, "main bus", 1, 2);
   gst_object_unref (bus);
+  gst_check_objects_destroyed_on_unref (pipeline, comp, nested_source, NULL);
 
   ges_deinit ();
 }