get_build_triggerurl logic fix

job.get_build_triggerurl had invalid logic for determining what build url to be using.  Parameterized builds can only be started via the rest API with the buildWithParameters endpoint even if you don't pass any parameters in.

diff --git a/jenkinsapi/job.py b/jenkinsapi/job.py
index 49f4972..1faad22 100644 (file)
--- a/jenkinsapi/job.py
+++ b/jenkinsapi/job.py
@@ -127,9 +127,9 @@ class Job(JenkinsBase, MutableJenkinsThing):
         return self._element_tree
 
     def get_build_triggerurl(self, build_params=None, files=None):
-        if build_params or files:
-            return "%s/buildWithParameters" % self.baseurl
-        return "%s/build" % self.baseurl
+        if len(self.get_params_list()) == 0:
+            return "%s/build" % self.baseurl
+        return "%s/buildWithParameters" % self.baseurl
 
     @staticmethod
     def _mk_json_from_build_parameters(build_params):