rmdemux: Don't ignore the return value of gst_segment_do_seek()
authorJan Schmidt <jan@centricular.com>
Wed, 1 Apr 2020 16:27:26 +0000 (03:27 +1100)
committerGStreamer Merge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Mon, 27 Jul 2020 07:26:37 +0000 (07:26 +0000)
If gst_segment_do_seek() fails, fail the seek.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-ugly/-/merge_requests/45>

gst/realmedia/rmdemux.c

index 6634c22..6cc659a 100644 (file)
@@ -527,8 +527,11 @@ gst_rmdemux_perform_seek (GstRMDemux * rmdemux, GstEvent * event)
   GST_LOG_OBJECT (rmdemux, "Took streamlock");
 
   if (event) {
-    gst_segment_do_seek (&rmdemux->segment, rate, format, flags,
-        cur_type, cur, stop_type, stop, &update);
+    if (!gst_segment_do_seek (&rmdemux->segment, rate, format, flags,
+            cur_type, cur, stop_type, stop, &update)) {
+      ret = FALSE;
+      goto done;
+    }
   }
 
   GST_DEBUG_OBJECT (rmdemux, "segment positions set to %" GST_TIME_FORMAT "-%"