drm/virtio: use kvmalloc for large allocations
authorSergey Senozhatsky <senozhatsky@chromium.org>
Thu, 5 Nov 2020 01:47:44 +0000 (10:47 +0900)
committerGerd Hoffmann <kraxel@redhat.com>
Thu, 5 Nov 2020 11:33:26 +0000 (12:33 +0100)
We observed that some of virtio_gpu_object_shmem_init() allocations
can be rather costly - order 6 - which can be difficult to fulfill
under memory pressure conditions. Switch to kvmalloc_array() in
virtio_gpu_object_shmem_init() and let the kernel vmalloc the entries
array.

Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Link: http://patchwork.freedesktop.org/patch/msgid/20201105014744.1662226-1-senozhatsky@chromium.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
drivers/gpu/drm/virtio/virtgpu_object.c

index 2d3aa7b..d9ad27e 100644 (file)
@@ -184,8 +184,9 @@ static int virtio_gpu_object_shmem_init(struct virtio_gpu_device *vgdev,
                *nents = shmem->pages->orig_nents;
        }
 
-       *ents = kmalloc_array(*nents, sizeof(struct virtio_gpu_mem_entry),
-                             GFP_KERNEL);
+       *ents = kvmalloc_array(*nents,
+                              sizeof(struct virtio_gpu_mem_entry),
+                              GFP_KERNEL);
        if (!(*ents)) {
                DRM_ERROR("failed to allocate ent list\n");
                return -ENOMEM;