clk: sci-clk: add slack to clk-set-rate passed to firmware
authorLokesh Vutla <lokeshvutla@ti.com>
Fri, 17 Jan 2020 06:27:30 +0000 (11:57 +0530)
committerLokesh Vutla <lokeshvutla@ti.com>
Mon, 20 Jan 2020 04:40:29 +0000 (10:10 +0530)
Add slack to the clock frequency parameters passed to firmware within
clk_set_rate. min-freq is changed to 0 and max-rate is changed to
ULONG_MAX. This fixes certain issues with pll clock rounding when the
firmware is not able to set the frequency exactly to the target, the
current implementation fails if the available frequency is even 1Hz off
the target. With the change, the firmware still tries its best to set
the frequency as close as possible to the target.

Reported-by: Vishal Mahaveer <vishalm@ti.com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
Signed-off-by: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
drivers/clk/clk-ti-sci.c

index 478349f..ed1facb 100644 (file)
@@ -106,8 +106,7 @@ static ulong ti_sci_clk_set_rate(struct clk *clk, ulong rate)
        k3_avs_notify_freq(clk->id, clk->data, rate);
 #endif
 
-       /* Ask for exact frequency by using same value for min/target/max */
-       ret = cops->set_freq(sci, clk->id, clk->data, rate, rate, rate);
+       ret = cops->set_freq(sci, clk->id, clk->data, 0, rate, ULONG_MAX);
        if (ret)
                dev_err(clk->dev, "%s: set_freq failed (%d)\n", __func__, ret);