fpga: stratix10-soc: Do not use ret uninitialized in s10_probe()
authorNathan Chancellor <nathan@kernel.org>
Tue, 30 Nov 2021 22:11:24 +0000 (15:11 -0700)
committerMoritz Fischer <mdf@kernel.org>
Fri, 3 Dec 2021 04:07:17 +0000 (20:07 -0800)
Clang warns:

drivers/fpga/stratix10-soc.c:431:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
        return ret;
               ^~~

ret is only assigned in an error path now so just return 0 directly.

Fixes: 4ba0b2c294fe ("fpga: mgr: Use standard dev_release for class driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/1517
Reviewed-by: Russ Weight <russell.h.weight@intel.com>
Reviewed-by: Tom Rix <trix@redhat.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
drivers/fpga/stratix10-soc.c

index 737d14c..357cea5 100644 (file)
@@ -428,7 +428,7 @@ static int s10_probe(struct platform_device *pdev)
        }
 
        platform_set_drvdata(pdev, mgr);
-       return ret;
+       return 0;
 
 probe_err:
        stratix10_svc_free_channel(priv->chan);