net: use dev_addr_set()

Use dev_addr_set() instead of writing directly to netdev->dev_addr
in various misc and old drivers.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 77dc79a7f5748b5e675104e94d9c6624743d079b..0c52612cb8e98e39aa09e04727e689c83a98861a 100644 (file)
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -4414,7 +4414,7 @@ static int bond_set_mac_address(struct net_device *bond_dev, void *addr)
        }
 
        /* success */
-       memcpy(bond_dev->dev_addr, ss->__data, bond_dev->addr_len);
+       dev_addr_set(bond_dev, ss->__data);
        return 0;
 
 unwind:

diff --git a/drivers/net/hamradio/baycom_epp.c b/drivers/net/hamradio/baycom_epp.c
index 775dcf4ebde580829431b8b5dad96d9a6267c1f4..f6428ff780abcd0d8d19f3eb705ca0719ffb19f5 100644 (file)
--- a/drivers/net/hamradio/baycom_epp.c
+++ b/drivers/net/hamradio/baycom_epp.c
@@ -791,7 +791,7 @@ static int baycom_set_mac_address(struct net_device *dev, void *addr)
        struct sockaddr *sa = (struct sockaddr *)addr;
 
        /* addr is an AX.25 shifted ASCII mac address */
-       memcpy(dev->dev_addr, sa->sa_data, dev->addr_len); 
+       dev_addr_set(dev, sa->sa_data);
        return 0;                                         
 }
 

diff --git a/drivers/net/hamradio/bpqether.c b/drivers/net/hamradio/bpqether.c
index d967b0748773d6415963b795fba3a0e9e00c24cb..1ac816164a9bb91d807f3db1b6c50eb86a34e546 100644 (file)
--- a/drivers/net/hamradio/bpqether.c
+++ b/drivers/net/hamradio/bpqether.c
@@ -302,7 +302,7 @@ static int bpq_set_mac_address(struct net_device *dev, void *addr)
 {
     struct sockaddr *sa = (struct sockaddr *)addr;
 
-    memcpy(dev->dev_addr, sa->sa_data, dev->addr_len);
+    dev_addr_set(dev, sa->sa_data);
 
     return 0;
 }

diff --git a/drivers/net/hamradio/dmascc.c b/drivers/net/hamradio/dmascc.c
index f4c3efc3e0745c621d8e1ff6bea66b1c8efb5be6..a4ba1b79d2d04f4c73f5a2ce055602eedc79baef 100644 (file)
--- a/drivers/net/hamradio/dmascc.c
+++ b/drivers/net/hamradio/dmascc.c
@@ -956,8 +956,7 @@ static int scc_send_packet(struct sk_buff *skb, struct net_device *dev)
 
 static int scc_set_mac_address(struct net_device *dev, void *sa)
 {
-       memcpy(dev->dev_addr, ((struct sockaddr *) sa)->sa_data,
-              dev->addr_len);
+       dev_addr_set(dev, ((struct sockaddr *)sa)->sa_data);
        return 0;
 }
 

diff --git a/drivers/net/hamradio/hdlcdrv.c b/drivers/net/hamradio/hdlcdrv.c
index 5805cfc83854bd5bc9218e5d0fce63af96a9b34a..ab5327acec220fe78e627cfab527076ec880b370 100644 (file)
--- a/drivers/net/hamradio/hdlcdrv.c
+++ b/drivers/net/hamradio/hdlcdrv.c
@@ -415,7 +415,7 @@ static int hdlcdrv_set_mac_address(struct net_device *dev, void *addr)
        struct sockaddr *sa = (struct sockaddr *)addr;
 
        /* addr is an AX.25 shifted ASCII mac address */
-       memcpy(dev->dev_addr, sa->sa_data, dev->addr_len); 
+       dev_addr_set(dev, sa->sa_data);
        return 0;                                         
 }
 

diff --git a/drivers/net/hamradio/scc.c b/drivers/net/hamradio/scc.c
index e0bb131a33d76b96703a6d24129f6964327a87eb..9b745d09d327a4da330030520a4b9d289fa2cb7c 100644 (file)
--- a/drivers/net/hamradio/scc.c
+++ b/drivers/net/hamradio/scc.c
@@ -1951,7 +1951,7 @@ static int scc_net_siocdevprivate(struct net_device *dev,
 static int scc_net_set_mac_address(struct net_device *dev, void *addr)
 {
        struct sockaddr *sa = (struct sockaddr *) addr;
-       memcpy(dev->dev_addr, sa->sa_data, dev->addr_len);
+       dev_addr_set(dev, sa->sa_data);
        return 0;
 }
 

diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c
index 6ddacbdb224ba1d2215fdb4281e60dbf087c1524..e557ccf98bcfd1b41a9309ef88741e9ba63be4be 100644 (file)
--- a/drivers/net/hamradio/yam.c
+++ b/drivers/net/hamradio/yam.c
@@ -1063,7 +1063,7 @@ static int yam_set_mac_address(struct net_device *dev, void *addr)
        struct sockaddr *sa = (struct sockaddr *) addr;
 
        /* addr is an AX.25 shifted ASCII mac address */
-       memcpy(dev->dev_addr, sa->sa_data, dev->addr_len);
+       dev_addr_set(dev, sa->sa_data);
        return 0;
 }
 

diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c
index 2a4892402ed8c46ba0b12c56a086c44c0a56052c..86ec5aae42891aa287a3eea3e91db4462990a350 100644 (file)
--- a/drivers/net/net_failover.c
+++ b/drivers/net/net_failover.c
@@ -748,8 +748,7 @@ struct failover *net_failover_create(struct net_device *standby_dev)
        failover_dev->hw_features |= NETIF_F_GSO_ENCAP_ALL;
        failover_dev->features |= failover_dev->hw_features;
 
-       memcpy(failover_dev->dev_addr, standby_dev->dev_addr,
-              failover_dev->addr_len);
+       dev_addr_set(failover_dev, standby_dev->dev_addr);
 
        failover_dev->min_mtu = standby_dev->min_mtu;
        failover_dev->max_mtu = standby_dev->max_mtu;

diff --git a/drivers/net/ntb_netdev.c b/drivers/net/ntb_netdev.c
index a5bab614ff8459788493297bdcaa897106f7f1ba..98ca6b18415e7e95ddcca890bd993416ebccfe59 100644 (file)
--- a/drivers/net/ntb_netdev.c
+++ b/drivers/net/ntb_netdev.c
@@ -428,7 +428,7 @@ static int ntb_netdev_probe(struct device *client_dev)
        ndev->watchdog_timeo = msecs_to_jiffies(NTB_TX_TIMEOUT_MS);
 
        eth_random_addr(ndev->perm_addr);
-       memcpy(ndev->dev_addr, ndev->perm_addr, ndev->addr_len);
+       dev_addr_set(ndev, ndev->perm_addr);
 
        ndev->netdev_ops = &ntb_netdev_ops;
        ndev->ethtool_ops = &ntb_ethtool_ops;

diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index dd7917cab2b124c2f5e697c221f8308c82235fba..8b2adc56b92a8ed8b08e9b8220ccaf43f841ce40 100644 (file)
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -1790,7 +1790,7 @@ static int team_set_mac_address(struct net_device *dev, void *p)
 
        if (dev->type == ARPHRD_ETHER && !is_valid_ether_addr(addr->sa_data))
                return -EADDRNOTAVAIL;
-       memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
+       dev_addr_set(dev, addr->sa_data);
        mutex_lock(&team->lock);
        list_for_each_entry(port, &team->port_list, list)
                if (team->ops.port_change_dev_addr)

diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index 142f70670f5c0accd4bd1ea64759f44e6ba1c58d..7a205ddf0060a3de8daf4b4984f407e7a73e2a3b 100644 (file)
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -2824,7 +2824,7 @@ vmxnet3_set_mac_addr(struct net_device *netdev, void *p)
        struct sockaddr *addr = p;
        struct vmxnet3_adapter *adapter = netdev_priv(netdev);
 
-       memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
+       dev_addr_set(netdev, addr->sa_data);
        vmxnet3_write_mac_addr(adapter, addr->sa_data);
 
        return 0;
@@ -3638,7 +3638,7 @@ vmxnet3_probe_device(struct pci_dev *pdev,
 #endif
 
        vmxnet3_read_mac_addr(adapter, mac);
-       memcpy(netdev->dev_addr,  mac, netdev->addr_len);
+       dev_addr_set(netdev, mac);
 
        netdev->netdev_ops = &vmxnet3_netdev_ops;
        vmxnet3_set_ethtool_ops(netdev);

diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
index 89d31adc3809b15da45b150a3585dc214ddf0bb5..282192b82404bb76a24b5a0a739c3479cf9c0210 100644 (file)
--- a/drivers/net/wan/lapbether.c
+++ b/drivers/net/wan/lapbether.c
@@ -301,7 +301,7 @@ static int lapbeth_set_mac_address(struct net_device *dev, void *addr)
 {
        struct sockaddr *sa = addr;
 
-       memcpy(dev->dev_addr, sa->sa_data, dev->addr_len);
+       dev_addr_set(dev, sa->sa_data);
        return 0;
 }
 

diff --git a/net/802/hippi.c b/net/802/hippi.c
index f80b33a8f7e0dd95f148af944d0ac09710cfe83a..887e73d520e4977fcb9830cad1933a2b55d9539b 100644 (file)
--- a/net/802/hippi.c
+++ b/net/802/hippi.c
@@ -121,7 +121,7 @@ int hippi_mac_addr(struct net_device *dev, void *p)
        struct sockaddr *addr = p;
        if (netif_running(dev))
                return -EBUSY;
-       memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
+       dev_addr_set(dev, addr->sa_data);
        return 0;
 }
 EXPORT_SYMBOL(hippi_mac_addr);

diff --git a/net/atm/br2684.c b/net/atm/br2684.c
index dd2a8dabed849b089f7f44e76492a2d995498329..11854fde52dbc57c96d2c77482903f8e08022afb 100644 (file)
--- a/net/atm/br2684.c
+++ b/net/atm/br2684.c
@@ -578,7 +578,7 @@ static int br2684_regvcc(struct atm_vcc *atmvcc, void __user * arg)
        if (list_empty(&brdev->brvccs) && !brdev->mac_was_set) {
                unsigned char *esi = atmvcc->dev->esi;
                if (esi[0] | esi[1] | esi[2] | esi[3] | esi[4] | esi[5])
-                       memcpy(net_dev->dev_addr, esi, net_dev->addr_len);
+                       dev_addr_set(net_dev, esi);
                else
                        net_dev->dev_addr[2] = 1;
        }

diff --git a/net/netrom/nr_dev.c b/net/netrom/nr_dev.c
index 29e418c8c6c30f1e331d614c7db4dd99778e2eee..d1ca413d3317c8856e307d1506691371c20cbcdc 100644 (file)
--- a/net/netrom/nr_dev.c
+++ b/net/netrom/nr_dev.c
@@ -111,7 +111,7 @@ static int __must_check nr_set_mac_address(struct net_device *dev, void *addr)
                ax25_listen_release((ax25_address *)dev->dev_addr, NULL);
        }
 
-       memcpy(dev->dev_addr, sa->sa_data, dev->addr_len);
+       dev_addr_set(dev, sa->sa_data);
 
        return 0;
 }

diff --git a/net/rose/rose_dev.c b/net/rose/rose_dev.c
index 051804fbee17f98906cdbc8bb348ef142c2a1584..2a35e188b389a8b6924e8cd13db657970feb94ec 100644 (file)
--- a/net/rose/rose_dev.c
+++ b/net/rose/rose_dev.c
@@ -69,7 +69,7 @@ static int rose_set_mac_address(struct net_device *dev, void *addr)
                rose_del_loopback_node((rose_address *)dev->dev_addr);
        }
 
-       memcpy(dev->dev_addr, sa->sa_data, dev->addr_len);
+       dev_addr_set(dev, sa->sa_data);
 
        return 0;
 }