usb: gadget: bcm63xx_udc: use list_for_each_entry_safe
authorGeliang Tang <geliangtang@163.com>
Fri, 18 Dec 2015 16:34:34 +0000 (00:34 +0800)
committerFelipe Balbi <balbi@ti.com>
Tue, 22 Dec 2015 18:08:40 +0000 (12:08 -0600)
Use list_for_each_entry_safe() instead of list_for_each_safe() to
simplify the code.

Signed-off-by: Geliang Tang <geliangtang@163.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/udc/bcm63xx_udc.c

index 8cbb003..f5fccb3 100644 (file)
@@ -1083,7 +1083,7 @@ static int bcm63xx_ep_disable(struct usb_ep *ep)
        struct bcm63xx_ep *bep = our_ep(ep);
        struct bcm63xx_udc *udc = bep->udc;
        struct iudma_ch *iudma = bep->iudma;
-       struct list_head *pos, *n;
+       struct bcm63xx_req *breq, *n;
        unsigned long flags;
 
        if (!ep || !ep->desc)
@@ -1099,10 +1099,7 @@ static int bcm63xx_ep_disable(struct usb_ep *ep)
        iudma_reset_channel(udc, iudma);
 
        if (!list_empty(&bep->queue)) {
-               list_for_each_safe(pos, n, &bep->queue) {
-                       struct bcm63xx_req *breq =
-                               list_entry(pos, struct bcm63xx_req, queue);
-
+               list_for_each_entry_safe(breq, n, &bep->queue, queue) {
                        usb_gadget_unmap_request(&udc->gadget, &breq->req,
                                                 iudma->is_tx);
                        list_del(&breq->queue);