media: atomisp-gc2235: drop an unused var
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 11 Nov 2021 22:58:38 +0000 (22:58 +0000)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 16 Nov 2021 14:37:08 +0000 (14:37 +0000)
Fix this clang Werror with W=1:

drivers/staging/media/atomisp/i2c/atomisp-gc2235.c:573:6: error: variable 'ret' set but not used [-Werror,-Wunused-but-set-variable]
        int ret = -1;
            ^

Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c

index 5e70852..0e6b2e6 100644 (file)
@@ -570,14 +570,16 @@ static int power_ctrl(struct v4l2_subdev *sd, bool flag)
 static int gpio_ctrl(struct v4l2_subdev *sd, bool flag)
 {
        struct gc2235_device *dev = to_gc2235_sensor(sd);
-       int ret = -1;
+       int ret;
 
        if (!dev || !dev->platform_data)
                return -ENODEV;
 
-       ret |= dev->platform_data->gpio1_ctrl(sd, !flag);
+       ret = dev->platform_data->gpio1_ctrl(sd, !flag);
        usleep_range(60, 90);
-       return dev->platform_data->gpio0_ctrl(sd, flag);
+       ret |= dev->platform_data->gpio0_ctrl(sd, flag);
+
+       return ret;
 }
 
 static int power_up(struct v4l2_subdev *sd)