spi: Allow SPI controller override device buswidth
authorJohn Garry <john.garry@huawei.com>
Fri, 28 Feb 2020 15:18:49 +0000 (23:18 +0800)
committerMark Brown <broonie@kernel.org>
Fri, 28 Feb 2020 18:01:42 +0000 (18:01 +0000)
Currently ACPI firmware description for a SPI device does not have any
method to describe the data buswidth on the board.

So even through the controller and device may support higher modes than
standard SPI, it cannot be assumed that the board does - as such, that
device is limited to standard SPI in such a circumstance.

As a workaround, allow the controller driver supply buswidth override bits,
which are used inform the core code that the controller driver knows the
buswidth supported on that board for that device.

A host controller driver might know this info from DMI tables, for example.

Signed-off-by: John Garry <john.garry@huawei.com>
Link: https://lore.kernel.org/r/1582903131-160033-2-git-send-email-john.garry@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi.c
include/linux/spi/spi.h

index 38b4c78..292f268 100644 (file)
@@ -510,6 +510,7 @@ struct spi_device *spi_alloc_device(struct spi_controller *ctlr)
        spi->dev.bus = &spi_bus_type;
        spi->dev.release = spidev_release;
        spi->cs_gpio = -ENOENT;
+       spi->mode = ctlr->buswidth_override_bits;
 
        spin_lock_init(&spi->statistics.lock);
 
@@ -2181,9 +2182,10 @@ static acpi_status acpi_register_spi_device(struct spi_controller *ctlr,
                return AE_NO_MEMORY;
        }
 
+
        ACPI_COMPANION_SET(&spi->dev, adev);
        spi->max_speed_hz       = lookup.max_speed_hz;
-       spi->mode               = lookup.mode;
+       spi->mode               |= lookup.mode;
        spi->irq                = lookup.irq;
        spi->bits_per_word      = lookup.bits_per_word;
        spi->chip_select        = lookup.chip_select;
index 6d16ba0..600e379 100644 (file)
@@ -481,6 +481,9 @@ struct spi_controller {
        /* spi_device.mode flags understood by this controller driver */
        u32                     mode_bits;
 
+       /* spi_device.mode flags override flags for this controller */
+       u32                     buswidth_override_bits;
+
        /* bitmask of supported bits_per_word for transfers */
        u32                     bits_per_word_mask;
 #define SPI_BPW_MASK(bits) BIT((bits) - 1)