radv: stop setting as_es for the GS stage
authorSamuel Pitoiset <samuel.pitoiset@gmail.com>
Tue, 23 Aug 2022 13:54:15 +0000 (15:54 +0200)
committerMarge Bot <emma+marge@anholt.net>
Thu, 1 Sep 2022 17:02:17 +0000 (17:02 +0000)
This doesn't make sense and it was assigned because the shader info
stuff was a complete mess.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18278>

src/amd/vulkan/radv_pipeline.c

index 6295fe4..a459882 100644 (file)
@@ -3329,11 +3329,9 @@ radv_fill_shader_info(struct radv_pipeline *pipeline,
 
       /* Copy data to merged stage. */
       if (pre_stage == MESA_SHADER_VERTEX) {
-         stages[MESA_SHADER_GEOMETRY].info.vs.as_es = stages[MESA_SHADER_VERTEX].info.vs.as_es;
          stages[MESA_SHADER_GEOMETRY].info.vs.num_linked_outputs =
             stages[MESA_SHADER_VERTEX].info.vs.num_linked_outputs;
       } else {
-         stages[MESA_SHADER_GEOMETRY].info.tes.as_es = stages[MESA_SHADER_TESS_EVAL].info.tes.as_es;
          stages[MESA_SHADER_GEOMETRY].info.tes.num_linked_outputs =
             stages[MESA_SHADER_TESS_EVAL].info.tes.num_linked_outputs;
          stages[MESA_SHADER_GEOMETRY].info.tes.num_linked_inputs =
@@ -3350,6 +3348,11 @@ radv_fill_shader_info(struct radv_pipeline *pipeline,
       }
 
       stages[pre_stage].info = stages[MESA_SHADER_GEOMETRY].info;
+      if (pre_stage == MESA_SHADER_VERTEX) {
+         stages[MESA_SHADER_VERTEX].info.vs.as_es = true;
+      } else {
+         stages[MESA_SHADER_TESS_EVAL].info.tes.as_es = true;
+      }
 
       filled_stages |= (1 << pre_stage);
       filled_stages |= (1 << MESA_SHADER_GEOMETRY);