net: enetc: remove redundant clearing of skb/xdp_frame pointer in TX conf path
authorVladimir Oltean <vladimir.oltean@nxp.com>
Fri, 16 Apr 2021 21:22:16 +0000 (00:22 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 17 Apr 2021 00:08:39 +0000 (17:08 -0700)
Later in enetc_clean_tx_ring we have:

/* Scrub the swbd here so we don't have to do that
 * when we reuse it during xmit
 */
memset(tx_swbd, 0, sizeof(*tx_swbd));

So these assignments are unnecessary.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/enetc/enetc.c

index 9a72608..c7f3c6e 100644 (file)
@@ -544,7 +544,6 @@ static bool enetc_clean_tx_ring(struct enetc_bdr *tx_ring, int napi_budget)
 
                if (xdp_frame) {
                        xdp_return_frame(xdp_frame);
-                       tx_swbd->xdp_frame = NULL;
                } else if (skb) {
                        if (unlikely(tx_swbd->skb->cb[0] &
                                     ENETC_F_TX_ONESTEP_SYNC_TSTAMP)) {
@@ -558,7 +557,6 @@ static bool enetc_clean_tx_ring(struct enetc_bdr *tx_ring, int napi_budget)
                                do_twostep_tstamp = false;
                        }
                        napi_consume_skb(skb, napi_budget);
-                       tx_swbd->skb = NULL;
                }
 
                tx_byte_cnt += tx_swbd->len;